All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Varsha Rao <rvarsha016@gmail.com>
Cc: Matthew Wilcox <mawilcox@microsoft.com>,
	Arnd Bergmann <arnd@arndb.de>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/5] drivers: char: Replace printk with pr_err.
Date: Fri, 7 Apr 2017 17:46:02 +0200	[thread overview]
Message-ID: <20170407154602.GB11575@kroah.com> (raw)
In-Reply-To: <58e77939.cca3620a.762de.3de9@mx.google.com>

On Fri, Apr 07, 2017 at 05:04:06PM +0530, Varsha Rao wrote:
> Replace printk with pr_err to fix the checkpatch issue.
> 
> Signed-off-by: Varsha Rao <rvarsha016@gmail.com>
> ---
>  drivers/char/misc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/char/misc.c b/drivers/char/misc.c
> index 1312e29..c9cd1ea 100644
> --- a/drivers/char/misc.c
> +++ b/drivers/char/misc.c
> @@ -294,7 +294,7 @@ static int __init misc_init(void)
>  	return 0;
>  
>  fail_printk:
> -	printk("unable to get major %d for misc devices\n", MISC_MAJOR);
> +	pr_err("unable to get major %d for misc devices\n", MISC_MAJOR);

Is pr_fmt properly set to use this?

thanks,

greg k-h

  reply	other threads:[~2017-04-07 15:46 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1491563538.git.rvarsha016@gmail.com>
2017-04-07 11:28 ` [PATCH 1/5] drivers: char: Replace "foo * bar" with "foo *bar" Varsha Rao
2017-04-07 11:31 ` [PATCH 2/5] drivers: char: Add space after ',' Varsha Rao
2017-04-07 11:32 ` [PATCH 3/5] drivers: char: Add blank line after declaration Varsha Rao
2017-04-07 11:34 ` [PATCH 4/5] drivers: char: Replace printk with pr_err Varsha Rao
2017-04-07 15:46   ` Greg Kroah-Hartman [this message]
2017-04-07 11:34 ` [PATCH 5/5] drivers: char: Replace bit operation functions with IDA allocator Varsha Rao
2017-04-07 15:45   ` Greg Kroah-Hartman
     [not found]     ` <CAAFX7JSPg1s8qT5Qr=Z+QnuUYpjvyFr7T_Qf_3D08ecT3P65SQ@mail.gmail.com>
     [not found]       ` <CAAFX7JSQ349OQ1kAXqGX7ozRTWdqqDm6tC1FW1MbyvjR6h32Bw@mail.gmail.com>
2017-04-09  5:20         ` Varsha Rao
     [not found] <cover.1491235332.git.rvarsha016@gmail.com>
2017-04-03 16:11 ` [PATCH 4/5] drivers: char: Replace printk with pr_err Varsha Rao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170407154602.GB11575@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=arnd@arndb.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mawilcox@microsoft.com \
    --cc=rvarsha016@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.