From: Brandon Williams <bmwill@google.com>
To: Jeff King <peff@peff.net>
Cc: Joachim Durchholz <jo@durchholz.org>,
Stefan Beller <sbeller@google.com>,
git@vger.kernel.org
Subject: Re: problem with backslash in directory name
Date: Fri, 7 Apr 2017 09:53:14 -0700 [thread overview]
Message-ID: <20170407165314.GB142670@google.com> (raw)
In-Reply-To: <20170407063057.yjbqavu4uiipslpc@sigill.intra.peff.net>
On 04/07, Jeff King wrote:
> On Fri, Apr 07, 2017 at 08:12:49AM +0200, Joachim Durchholz wrote:
>
> > So... something inside "git submodule add" is replacing the \b with a
> > backspace control code.
> > [...]
> > Whatever that "something" is, it is not doing shell expansion, otherwise it
> > would have started an interactive calculator session.
>
> Probably it's "read" which does backslash expansion, but nothing else.
> Just grepping git-submodule.sh, some of the "read" calls should probably
> be "read -r" (I also don't know how some of those loops would cope with
> a submodule name that needed quoting).
So I blindly converted all "read" calls to "read -r" and tested against
the case Joachim ran into and it seems to solve the issues. All test
still pass too (though that may not mean too much).
--
Brandon Williams
next prev parent reply other threads:[~2017-04-07 16:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-07 6:12 problem with backslash in directory name Joachim Durchholz
2017-04-07 6:30 ` Jeff King
2017-04-07 8:24 ` Joachim Durchholz
2017-04-07 8:40 ` Joachim Durchholz
2017-04-07 16:53 ` Brandon Williams [this message]
2017-04-07 16:55 ` Stefan Beller
2017-04-07 17:23 ` [PATCH] submodule: prevent backslash expantion in submodule names Brandon Williams
2017-04-07 17:35 ` Joachim Durchholz
2017-04-08 10:59 ` Jeff King
2017-04-08 20:32 ` Joachim Durchholz
2017-04-17 3:09 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170407165314.GB142670@google.com \
--to=bmwill@google.com \
--cc=git@vger.kernel.org \
--cc=jo@durchholz.org \
--cc=peff@peff.net \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.