From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=fm1; bh=8rnZ7KpLN9rym/go0w KgnJ3FeFENgVTwJECSfMf0+w0=; b=n78oZlGopEzW2/lQaku1w7evbv3SnuiJPt LVjJj8UPp46IPSdx4GbztTurVo23+hcXlTATU247349HEbKo3+ol0vOzuj3MUnPY Ohd9u+o+7ya7kwLYTsLs/hFeNPrzLfqEQW3quuhdSzaVYl9hABkaO2mQhCqLtd1Z 7eWU4IViIJnL7dY3EyvU/ItTJEVszcgP41+zc+Gw5J/OyKQrLHLfhQzX39Z04pgy cqOHHauqlQKyeo6cZxyjm7C5Wz0xB93ZMjFlYEDT0QiATLIPdWon18bHL9GSus8n Uku5mOcfilBAs6+Vxa8HI2ncepWB2vSi4xTPQ0I1BAr4My60PdUg== Date: Fri, 7 Apr 2017 21:16:49 +0300 From: Ido Schimmel Message-ID: <20170407181649.GA21938@splinter> References: <20170407124915.15508-1-idosch@mellanox.com> <20170407101055.745d95d0@plumbers-lap.home.lan> <3d567660-7fa5-979e-3097-89427270e554@cumulusnetworks.com> <20170407112206.77b515cd@plumbers-lap.home.lan> <23249e09-a712-920f-9a9f-850055aaf3af@cumulusnetworks.com> <20170407113615.15891fde@plumbers-lap.home.lan> <20170407133753.1602f3cd@plumbers-lap.home.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170407133753.1602f3cd@plumbers-lap.home.lan> Subject: Re: [Bridge] [PATCH net] bridge: netlink: register netdevice before executing changelink List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stephen Hemminger Cc: cera@cera.cz, mlxsw@mellanox.com, Nikolay Aleksandrov , netdev@vger.kernel.org, peter@svinota.eu, bridge@lists.linux-foundation.org, idosch@mellanox.com, davem@davemloft.net On Fri, Apr 07, 2017 at 01:37:53PM -0400, Stephen Hemminger wrote: > Fix it right now. The patch you propose is too half baked. Given this patch needs to be back ported to three different stable kernels I tried to keep the amount of changes to a minimum while fixing the bug. I'll work on the ndo_uninit() patch and submit it. Then people can decide which course of action they're more comfortable with. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ido Schimmel Subject: Re: [PATCH net] bridge: netlink: register netdevice before executing changelink Date: Fri, 7 Apr 2017 21:16:49 +0300 Message-ID: <20170407181649.GA21938@splinter> References: <20170407124915.15508-1-idosch@mellanox.com> <20170407101055.745d95d0@plumbers-lap.home.lan> <3d567660-7fa5-979e-3097-89427270e554@cumulusnetworks.com> <20170407112206.77b515cd@plumbers-lap.home.lan> <23249e09-a712-920f-9a9f-850055aaf3af@cumulusnetworks.com> <20170407113615.15891fde@plumbers-lap.home.lan> <20170407133753.1602f3cd@plumbers-lap.home.lan> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: cera@cera.cz, mlxsw@mellanox.com, Nikolay Aleksandrov , netdev@vger.kernel.org, peter@svinota.eu, bridge@lists.linux-foundation.org, idosch@mellanox.com, davem@davemloft.net To: Stephen Hemminger Return-path: Content-Disposition: inline In-Reply-To: <20170407133753.1602f3cd@plumbers-lap.home.lan> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: bridge-bounces@lists.linux-foundation.org Errors-To: bridge-bounces@lists.linux-foundation.org List-Id: netdev.vger.kernel.org On Fri, Apr 07, 2017 at 01:37:53PM -0400, Stephen Hemminger wrote: > Fix it right now. The patch you propose is too half baked. Given this patch needs to be back ported to three different stable kernels I tried to keep the amount of changes to a minimum while fixing the bug. I'll work on the ndo_uninit() patch and submit it. Then people can decide which course of action they're more comfortable with.