All of lore.kernel.org
 help / color / mirror / Atom feed
From: Al Viro <viro@ZenIV.linux.org.uk>
To: linux-arch@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: [RFC] why do we still keep __{get,put}_user_unaligned()?
Date: Sat, 8 Apr 2017 07:21:16 +0100	[thread overview]
Message-ID: <20170408062115.GZ29622@ZenIV.linux.org.uk> (raw)

	Right now we have no users of __get_user_unaligned() outside of
arch/* and only 4 users of __put_user_unaligned() outside of arch/*.

	All 4 are in compat_sys_getdents64().  For storing
->d_ino and ->d_off in
struct linux_dirent64 {
        u64             d_ino;
        s64             d_off;
        unsigned short  d_reclen;
        unsigned char   d_type;
        char            d_name[0];
};
in case 32bit userland has weaker alignment requirements for that thing
and passes us a pointer that would've been aligned for 32bit, but not
for 64bit ABI.  Which architecture would that be, though?

	arm, mips, powerpc, sparc and s390 have that thing 64bit-aligned
in 32bit ABI (both of them in case of mips).  And since native getdents()
does *not* maintain more than that when padding an entry, we'd better have
put_user() of 64bit values work for any 64bit-aligned pointer.  I hadn't
checked actual cross-compile for tile, but judging by their compat.h they
are not suffering from that kind of braindamage either.

	x86 does, indeed, have weaker alignment in 32bit ABI.  It also
has __put_user_unaligned defined as __put_user.

	Is there any reason to keep those around?  As it is, the only places
that need those are m68k and arm binfmt-flat, and these boil down to "can this
CPU flavour do unaligned access?", with "use __get_user/__put_user" and
"use __copy_from_user/__copy_to_user" as outcomes.  Nothing more fancy...

             reply	other threads:[~2017-04-08  6:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-08  6:21 Al Viro [this message]
2017-04-08 18:36 ` [PATCH] remove compat_sys_getdents64() (was Re: [RFC] why do we still keep __{get,put}_user_unaligned()?) Al Viro
2017-04-08 18:54   ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170408062115.GZ29622@ZenIV.linux.org.uk \
    --to=viro@zeniv.linux.org.uk \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.