From: Lukas Wunner <lukas@wunner.de>
To: Hans de Goede <hdegoede@redhat.com>
Cc: "Rafael J . Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>, Sebastian Reichel <sre@kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Robert Moore <robert.moore@intel.com>,
linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org,
Mika Westerberg <mika.westerberg@linux.intel.com>
Subject: Re: [PATCH v3 1/4] ACPI: utils: Add new acpi_dev_present helper
Date: Sat, 8 Apr 2017 23:40:44 +0200 [thread overview]
Message-ID: <20170408214044.GA3894@wunner.de> (raw)
In-Reply-To: <20170408212346.8227-1-hdegoede@redhat.com>
On Sat, Apr 08, 2017 at 11:23:43PM +0200, Hans de Goede wrote:
[snip]
> Changes in v3:
> -memset the entire acpi_dev_present_info struct, this fixes
> acpi_device_id.cls not getting cleared
[snip]
> +bool acpi_dev_present(const char *hid, const char *uid, int hrv)
> +{
> + struct acpi_dev_present_info match;
> + struct device *dev;
> +
> + memset(&match, 0, sizeof(match));
Just use
struct acpi_dev_present_info match = {};
That's how I did it in parse_acpi_path() in commit 46cd4b75cd0e.
Copy+paste is hard. ;-)
Best regards,
Lukas
prev parent reply other threads:[~2017-04-08 21:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-08 21:23 [PATCH v3 1/4] ACPI: utils: Add new acpi_dev_present helper Hans de Goede
2017-04-08 21:23 ` [PATCH v3 2/4] ACPI: battery: Fix acpi_battery_exit on acpi_battery_init_async errors Hans de Goede
2017-04-08 21:23 ` [PATCH v3 3/4] ACPI: battery: Add a blacklist with PMIC ACPI HIDs with a native battery driver Hans de Goede
2017-04-08 21:23 ` [PATCH v3 4/4] ACPI: ac: Add a blacklist with PMIC ACPI HIDs with a native charger driver Hans de Goede
2017-04-08 21:40 ` Lukas Wunner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170408214044.GA3894@wunner.de \
--to=lukas@wunner.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rjw@rjwysocki.net \
--cc=robert.moore@intel.com \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.