From: Alexey Dobriyan <adobriyan@gmail.com>
To: steffen.klassert@secunet.com
Cc: edumazet@google.com, davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH net-next 0/1 v2] skbuff: Extend gso_type to unsigned int.
Date: Sun, 9 Apr 2017 19:07:24 +0300 [thread overview]
Message-ID: <20170409160724.GA28980@avx2> (raw)
> struct skb_shared_info {
> + unsigned short _unused;
> unsigned char nr_frags;
This makes _all_ fields to be accessed with offset, but if you move
padding down, at least ->nr_frags will enjoy clean and simple [R64]
addressing.
On allyesconfig-ish kernel:
before: +542 = 720-178
after: -158 = 53-211 (negative, because 16-bit field became 32-bit)
You may want to add configurable redzone there instead of padding
if that what you want. 2 bytes is nothing.
next reply other threads:[~2017-04-09 16:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-09 16:07 Alexey Dobriyan [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-04-08 18:36 [PATCH net-next 0/1 v2] skbuff: Extend gso_type to unsigned int Steffen Klassert
2017-04-08 18:36 ` Steffen Klassert
2017-04-08 18:55 ` Eric Dumazet
2017-04-08 19:32 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170409160724.GA28980@avx2 \
--to=adobriyan@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=netdev@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.