From: Greg KH <greg@kroah.com>
To: "Arthur Brainville (Ybalrid)" <ybalrid@ybalrid.info>
Cc: abbotti@mev.co.uk, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: comedidev.h comedi_lrange should be const struct
Date: Sun, 9 Apr 2017 21:02:03 +0200 [thread overview]
Message-ID: <20170409190203.GA26797@kroah.com> (raw)
In-Reply-To: <20170409142812.3356-1-ybalrid@ybalrid.info>
On Sun, Apr 09, 2017 at 04:28:12PM +0200, Arthur Brainville (Ybalrid) wrote:
> According to checkpatch.pl, comedi_lrange should be declared as `const
> struct` instead of `struct` in driver/staging/comedidev.h
>
> Signed-off-by: Arthur Brainville (Ybalrid) <ybalrid@ybalrid.info>
> ---
> drivers/staging/comedi/comedidev.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/comedi/comedidev.h b/drivers/staging/comedi/comedidev.h
> index 1bb9986f865e..82df090783b5 100644
> --- a/drivers/staging/comedi/comedidev.h
> +++ b/drivers/staging/comedi/comedidev.h
> @@ -623,7 +623,7 @@ extern const struct comedi_lrange range_unknown;
> * There may also be a flag that indicates the minimum and maximum are merely
> * scale factors for an unknown, external reference.
> */
> -struct comedi_lrange {
> +const struct comedi_lrange {
> int length;
> struct comedi_krange range[];
> };
Huh? Please explain how this change is correct.
greg k-h
next prev parent reply other threads:[~2017-04-09 19:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-09 14:28 [PATCH] Staging: comedidev.h comedi_lrange should be const struct Arthur Brainville (Ybalrid)
2017-04-09 16:22 ` kbuild test robot
2017-04-09 19:02 ` Greg KH [this message]
2017-04-10 2:51 ` kbuild test robot
2017-04-10 17:45 ` [PATCH] checkpatch: Avoid suggesting struct definitions should be const Joe Perches
2017-04-10 18:56 ` Arthur Brainville (Ybalrid)
[not found] <20170409194120.GA23199@Leliel>
2017-04-10 15:25 ` [PATCH] Staging: comedidev.h comedi_lrange should be const struct Arthur Brainville
2017-04-10 20:01 ` Greg KH
2017-04-10 20:17 ` Arthur Brainville (Ybalrid)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170409190203.GA26797@kroah.com \
--to=greg@kroah.com \
--cc=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ybalrid@ybalrid.info \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.