Re: [Qemu-devel] [PATCH 16/21] ppc/pnv: generate an OEM SEL event on shutdown

[David Gibson <david@gibson.dropbear.id.au>]

[-- Attachment #1: Type: text/plain, Size: 3971 bytes --]

On Wed, Apr 05, 2017 at 02:41:41PM +0200, Cédric Le Goater wrote:
> OpenPOWER systems expect to be notified with such an event before a
> shutdown or a reboot. An OEM SEL message is sent with specific
> identifiers and a user data containing the request : OFF or REBOOT.
> 
> Signed-off-by: Cédric Le Goater <clg@kaod.org>

Reviewed-by: David Gibson <david@gibson.dropbear.id.au>

> ---
>  hw/ppc/pnv.c         | 14 ++++++++++++++
>  hw/ppc/pnv_bmc.c     | 42 ++++++++++++++++++++++++++++++++++++++++++
>  include/hw/ppc/pnv.h |  3 +++
>  3 files changed, 59 insertions(+)
> 
> diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c
> index c7caecad0aa6..df0a88c3e252 100644
> --- a/hw/ppc/pnv.c
> +++ b/hw/ppc/pnv.c
> @@ -467,6 +467,15 @@ static void *powernv_create_fdt(MachineState *machine)
>      return fdt;
>  }
>  
> +static void pnv_powerdown_notify(Notifier *n, void *opaque)
> +{
> +    PnvMachineState *pnv = POWERNV_MACHINE(qdev_get_machine());
> +
> +    if (pnv->bmc) {
> +        pnv_bmc_powerdown(pnv->bmc);
> +    }
> +}
> +
>  static void ppc_powernv_reset(void)
>  {
>      MachineState *machine = MACHINE(qdev_get_machine());
> @@ -662,6 +671,11 @@ static void ppc_powernv_init(MachineState *machine)
>  
>      /* Create an RTC ISA device too */
>      rtc_init(pnv->isa_bus, 2000, NULL);
> +
> +    /* OpenPOWER systems use a IPMI SEL Event message to notify the
> +     * host to powerdown */
> +    pnv->powerdown_notifier.notify = pnv_powerdown_notify;
> +    qemu_register_powerdown_notifier(&pnv->powerdown_notifier);
>  }
>  
>  /*
> diff --git a/hw/ppc/pnv_bmc.c b/hw/ppc/pnv_bmc.c
> index 2998530dc4c0..d9ed774acbac 100644
> --- a/hw/ppc/pnv_bmc.c
> +++ b/hw/ppc/pnv_bmc.c
> @@ -32,6 +32,48 @@
>  /* TODO: include definition in ipmi.h */
>  #define IPMI_SDR_FULL_TYPE 1
>  
> +/*
> + * OEM SEL Event data packet sent by BMC in response of a Read Event
> + * Message Buffer command
> + */
> +typedef struct OemSel {
> +    /* SEL header */
> +    uint8_t id[2];
> +    uint8_t type;
> +    uint8_t timestamp[4];
> +    uint8_t manuf_id[3];
> +
> +    /* OEM SEL data (6 bytes) follows */
> +    uint8_t netfun;
> +    uint8_t cmd;
> +    uint8_t data[4];
> +} OemSel;
> +
> +#define SOFT_OFF        0x00
> +#define SOFT_REBOOT     0x01
> +
> +static void pnv_gen_oem_sel(Object *obj, uint8_t reboot)
> +{
> +    /* IPMI SEL Event are 16 bytes long */
> +    OemSel sel = {
> +        .id        = { 0x55 , 0x55 },
> +        .type      = 0xC0, /* OEM */
> +        .manuf_id  = { 0x0, 0x0, 0x0 },
> +        .timestamp = { 0x0, 0x0, 0x0, 0x0 },
> +        .netfun    = 0x3A, /* IBM */
> +        .cmd       = 0x04, /* AMI OEM SEL Power Notification */
> +        .data      = { reboot, 0xFF, 0xFF, 0xFF },
> +    };
> +
> +    ipmi_bmc_gen_event(IPMI_BMC(obj), (uint8_t *) &sel,
> +                       0 /* do not log the event */);
> +}
> +
> +void pnv_bmc_powerdown(Object *obj)
> +{
> +    pnv_gen_oem_sel(obj, SOFT_OFF);
> +}
> +
>  void pnv_bmc_populate_sensors(Object *bmc, void *fdt)
>  {
>      int offset;
> diff --git a/include/hw/ppc/pnv.h b/include/hw/ppc/pnv.h
> index 050763f6cf54..b70a13bd4175 100644
> --- a/include/hw/ppc/pnv.h
> +++ b/include/hw/ppc/pnv.h
> @@ -132,6 +132,8 @@ typedef struct PnvMachineState {
>      uint32_t     cpld_irqstate;
>  
>      Object       *bmc;
> +
> +    Notifier     powerdown_notifier;
>  } PnvMachineState;
>  
>  #define PNV_FDT_ADDR          0x01000000
> @@ -141,6 +143,7 @@ typedef struct PnvMachineState {
>   * BMC helpers
>   */
>  void pnv_bmc_populate_sensors(Object *objbmc, void *fdt);
> +void pnv_bmc_powerdown(Object *objbmc);
>  
>  /*
>   * POWER8 MMIO base addresses

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]