From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:53338 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753414AbdDJPLc (ORCPT ); Mon, 10 Apr 2017 11:11:32 -0400 Date: Mon, 10 Apr 2017 17:11:17 +0200 From: "gregkh@linuxfoundation.org" To: alexander.levin@verizon.com Cc: "stable@vger.kernel.org" Subject: Re: [PATCH for 4.9 01/98] drm/sun4i: tcon: Move SoC specific quirks to a DT matched data structure Message-ID: <20170410151117.GA26545@kroah.com> References: <20170404193158.19041-1-alexander.levin@verizon.com> <20170404193158.19041-2-alexander.levin@verizon.com> <20170405101649.GB31998@kroah.com> <20170405140747.7hl2h63fk5cqcyvl@sasha-lappy> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170405140747.7hl2h63fk5cqcyvl@sasha-lappy> Sender: stable-owner@vger.kernel.org List-ID: On Wed, Apr 05, 2017 at 02:07:46PM +0000, alexander.levin@verizon.com wrote: > On Wed, Apr 05, 2017 at 12:16:49PM +0200, gregkh@linuxfoundation.org wrote: > > On Tue, Apr 04, 2017 at 07:32:02PM +0000, alexander.levin@verizon.com wrote: > > > From: Chen-Yu Tsai > > > > > > [ Upstream commit 91ea2f29cba6a7fe035ea232e4f981211a9fce5d ] > > > > > > We already have some differences between the 2 supported SoCs. > > > More will be added as we support other SoCs. To avoid bloating > > > the probe function with even more conditionals, move the quirks > > > to a separate data structure that's tied to the compatible string. > > > > > > Signed-off-by: Chen-Yu Tsai > > > Signed-off-by: Maxime Ripard > > > Signed-off-by: Sasha Levin > > > --- > > > drivers/gpu/drm/sun4i/sun4i_tcon.c | 33 ++++++++++++++++++--------------- > > > drivers/gpu/drm/sun4i/sun4i_tcon.h | 11 +++++++---- > > > 2 files changed, 25 insertions(+), 19 deletions(-) > > > > What new hardware is this enabling? It looks like this is just code > > reorginizing to me, to make things easier for later patches, which I > > don't see in this patch series... > > Uh, right, I pulled it in for: > > 49c440e87cd ("drm/sun4i: Add compatible strings for A31/A31s display pipelines") > 93a5ec14da2 ("drm/sun4i: Add compatible string for A31/A31s TCON (timing controller)") > > I'm not sure where they went, can you pull them in please? Now pulled in, thanks! greg k-h