From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753479AbdDJSbd (ORCPT ); Mon, 10 Apr 2017 14:31:33 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:56759 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752689AbdDJSbc (ORCPT ); Mon, 10 Apr 2017 14:31:32 -0400 Date: Mon, 10 Apr 2017 11:31:27 -0700 From: "Paul E. McKenney" To: Steven Rostedt Cc: linux-kernel@vger.kernel.org, Ingo Molnar , Andrew Morton Subject: Re: [PATCH 2/7 v3] tracing: Replace the per_cpu() with __this_cpu*() in trace_stack.c Reply-To: paulmck@linux.vnet.ibm.com References: <20170410181005.420764935@goodmis.org> <20170410181151.010996809@goodmis.org> <20170410181515.GV1600@linux.vnet.ibm.com> <20170410142034.5ef57d5b@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170410142034.5ef57d5b@gandalf.local.home> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-GCONF: 00 x-cbid: 17041018-0036-0000-0000-000001D84177 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00006912; HX=3.00000240; KW=3.00000007; PH=3.00000004; SC=3.00000208; SDB=6.00845665; UDB=6.00417042; IPR=6.00624098; BA=6.00005281; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00014995; XFM=3.00000013; UTC=2017-04-10 18:31:29 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17041018-0037-0000-0000-00003F9899A6 Message-Id: <20170410183127.GZ1600@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-04-10_14:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1702020001 definitions=main-1704100146 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 10, 2017 at 02:20:34PM -0400, Steven Rostedt wrote: > On Mon, 10 Apr 2017 11:15:15 -0700 > "Paul E. McKenney" wrote: > > > On Mon, Apr 10, 2017 at 02:10:07PM -0400, Steven Rostedt wrote: > > > From: "Steven Rostedt (VMware)" > > > > > > The updates to the trace_active per cpu variable can be updated with the > > > __this_cpu_*() functions as it only gets updated on the CPU that the variable > > > is on. > > > > > > Thanks to Paul McKenney for suggesting __this_cpu_* instead of this_cpu_*. > > > > > > Signed-off-by: Steven Rostedt (VMware) > > > > Acked-by: Paul E. McKenney > > > > Paul, I added your ack on 7/7 as well. Is that fine with you. Also, did > you want me to keep your ack on this one? Yes to both. Our emails crossed. ;-) Thanx, Paul