From: Julien Desfossez <ju@klipix.org>
To: David Ahern <dsa@cumulusnetworks.com>
Cc: Jesper Dangaard Brouer <brouer@redhat.com>,
John Fastabend <john.fastabend@gmail.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"xdp-newbies@vger.kernel.org" <xdp-newbies@vger.kernel.org>
Subject: Re: xdp on virtio_net
Date: Mon, 10 Apr 2017 19:39:52 -0400 [thread overview]
Message-ID: <20170410233952.GA4836@microsoft.com> (raw)
In-Reply-To: <eefb8af4-a09f-93a8-9112-f6c1da41ef98@cumulusnetworks.com>
On 10-Apr-2017 02:45:10 PM, David Ahern wrote:
> On 4/10/17 2:43 PM, Jesper Dangaard Brouer wrote:
> >> So now, all I need is to make this check pass:
> >> if (virtio_has_feature(vi->vdev, VIRTIO_NET_F_GUEST_TSO4) ||
> >> virtio_has_feature(vi->vdev, VIRTIO_NET_F_GUEST_TSO6) ||
> >> virtio_has_feature(vi->vdev, VIRTIO_NET_F_GUEST_ECN) ||
> >> virtio_has_feature(vi->vdev, VIRTIO_NET_F_GUEST_UFO)) {
> >> netdev_warn(dev, "can't set XDP while host is implementing LRO, disable LRO first\n");
> >> return -EOPNOTSUPP;
> >> }
> >>
> >> I know running ethtool commands to disable those features does not change the
> >> result.
> >>
> >> If you have an idea on how to solve this problem that would be great.
> >
> > Maybe someone on the xdp-newbies@vger.kernel.org list can help?
> >
>
> Pass this on the qemu command line for the device you want to run xdp:
>
> "gso=off,guest_tso4=off,guest_tso6=off,guest_ecn=off,guest_ufo=off"
Awesome, it works !
If others want to do it with libvirt/virsh instead of the qemu command line,
here is the right incantation to add to the "interface" section (with 4 vCPUs):
<driver name='vhost' queues='8'>
<host tso4='off' tso6='off' ecn='off' ufo='off'/>
<guest tso4='off' tso6='off' ecn='off' ufo='off'/>
</driver>
Thanks !
Julien
prev parent reply other threads:[~2017-04-10 23:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <8ec1432f-b032-0e2c-5e07-cee4550f97b7@klipix.org>
[not found] ` <20170408140110.27d0fe80@redhat.com>
[not found] ` <20170410161833.GK4714@microsoft.com>
2017-04-10 20:43 ` xdp on virtio_net Jesper Dangaard Brouer
2017-04-10 20:45 ` David Ahern
2017-04-10 23:39 ` Julien Desfossez [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170410233952.GA4836@microsoft.com \
--to=ju@klipix.org \
--cc=brouer@redhat.com \
--cc=dsa@cumulusnetworks.com \
--cc=john.fastabend@gmail.com \
--cc=mst@redhat.com \
--cc=xdp-newbies@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.