From: Fam Zheng <famz@redhat.com>
To: Max Reitz <mreitz@redhat.com>
Cc: qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
Ronnie Sahlberg <ronniesahlberg@gmail.com>,
qemu-block@nongnu.org, Peter Lieven <pl@kamp.de>,
Kevin Wolf <kwolf@redhat.com>
Subject: Re: [Qemu-devel] [PATCH for-2.9] iscsi: Fix iscsi_create
Date: Tue, 11 Apr 2017 21:05:58 +0800 [thread overview]
Message-ID: <20170411130558.GD8507@lemon> (raw)
In-Reply-To: <24011a9e-eab2-60b4-48a2-0e5ec1f4cf12@redhat.com>
On Mon, 04/10 17:17, Max Reitz wrote:
> > bs_options = qdict_new();
> > qdict_put(bs_options, "filename", qstring_from_str(filename));
>
> Doesn't the below change make this qdict_put() superfluous?
You are right, bdrv_iscsi.bdrv_needs_filename is false.
Fam
next prev parent reply other threads:[~2017-04-11 13:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-10 7:54 [Qemu-devel] [PATCH for-2.9] iscsi: Fix iscsi_create Fam Zheng
2017-04-10 14:58 ` Eric Blake
2017-04-10 15:17 ` Max Reitz
2017-04-11 13:05 ` Fam Zheng [this message]
2017-04-11 13:18 ` Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170411130558.GD8507@lemon \
--to=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=pl@kamp.de \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=ronniesahlberg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.