All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: killertofu@gmail.com
Cc: linux-input@vger.kernel.org
Subject: [bug report] HID: wacom: Introduce new 'touch_input' device
Date: Wed, 12 Apr 2017 23:31:23 +0300	[thread overview]
Message-ID: <20170412203123.GA3915@mwanda> (raw)

Hello Jason Gerecke,

This is a semi-automatic email about new static checker warnings.

The patch 2a6cdbdd4cc0: "HID: wacom: Introduce new 'touch_input' 
device" from Jun 15, 2015, leads to the following Smatch complaint:

drivers/hid/wacom_wac.c:1586 wacom_tpc_irq()
	 error: we previously assumed 'wacom->touch_input' could be null (see line 1577)

drivers/hid/wacom_wac.c
  1576				"%s: received report #%d\n", __func__, data[0]);
  1577		else if (wacom->touch_input)
                         ^^^^^^^^^^^^^^^^^^
Patch adds new check for NULL.

  1578			dev_dbg(wacom->touch_input->dev.parent,
  1579				"%s: received report #%d\n", __func__, data[0]);
  1580	
  1581		switch (len) {
  1582		case WACOM_PKGLEN_TPC1FG:
  1583			return wacom_tpc_single_touch(wacom, len);
  1584	
  1585		case WACOM_PKGLEN_TPC2FG:
  1586			return wacom_tpc_mt_touch(wacom);
                                                  ^^^^^
Not checked inside this function call.

  1587	
  1588		case WACOM_PKGLEN_PENABLED:

regards,
dan carpenter

             reply	other threads:[~2017-04-12 20:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-12 20:31 Dan Carpenter [this message]
2017-04-25 18:29 ` [PATCH] HID: wacom: Have wacom_tpc_irq guard against possible NULL dereference Jason Gerecke
2017-04-25 20:56   ` Ping Cheng
2017-05-02 21:04     ` Jason Gerecke
2017-05-03  9:26       ` Jiri Kosina
2017-05-05 12:53   ` Jiri Kosina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170412203123.GA3915@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=killertofu@gmail.com \
    --cc=linux-input@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.