From: Ralf Baechle <ralf@linux-mips.org>
To: James Hogan <james.hogan@imgtec.com>
Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
Jason Wessel <jason.wessel@windriver.com>,
linux-mips@linux-mips.org, stable@vger.kernel.org
Subject: Re: [PATCH] MIPS: KGDB: Use kernel context for sleeping threads
Date: Wed, 12 Apr 2017 22:33:04 +0200 [thread overview]
Message-ID: <20170412203304.GA3990@linux-mips.org> (raw)
In-Reply-To: <20170330155526.GA21492@jhogan-linux.le.imgtec.org>
On Thu, Mar 30, 2017 at 04:55:26PM +0100, James Hogan wrote:
> Hi Sergei,
>
> On Thu, Mar 30, 2017 at 06:42:08PM +0300, Sergei Shtylyov wrote:
> > On 03/30/2017 06:06 PM, James Hogan wrote:
> > > @@ -254,25 +251,46 @@ void sleeping_thread_to_gdb_regs(unsigned long *gdb_regs, struct task_struct *p)
> > > #endif
> > >
> > > for (reg = 0; reg < 16; reg++)
> > > - *(ptr++) = regs->regs[reg];
> > > + *(ptr++) = 0;
> >
> > Parens are not really necessary, you can get rid of them, while at it.
>
> While not technically required, I disagree that we should get rid of
> them, simply because after coding in C for almost 20 years I still had
> to look at an operator precedence table to check which of post++ and
> dereference operators take precedence.
I strongly side with James on this one so I applied the patch as-is.
Ralf
prev parent reply other threads:[~2017-04-12 20:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-30 15:06 [PATCH] MIPS: KGDB: Use kernel context for sleeping threads James Hogan
2017-03-30 15:06 ` James Hogan
2017-03-30 15:42 ` Sergei Shtylyov
2017-03-30 15:55 ` James Hogan
2017-03-30 15:55 ` James Hogan
2017-04-12 20:33 ` Ralf Baechle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170412203304.GA3990@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=james.hogan@imgtec.com \
--cc=jason.wessel@windriver.com \
--cc=linux-mips@linux-mips.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.