From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Sakkinen Subject: Re: [PATCH 4/4] tpm: introduce tpm_extend_pcr_digests() Date: Wed, 12 Apr 2017 23:59:50 +0300 Message-ID: <20170412205950.apllep2f6py5mhpt@intel.com> References: <20170329102452.32212-1-roberto.sassu@huawei.com> <20170329102452.32212-5-roberto.sassu@huawei.com> <20170405121416.2rly5pizs2hll56k@intel.com> <259b67e8-216b-ad91-52c3-c4b39a8f3d1c@huawei.com> <88284005-3a53-1b37-e1f2-bfa88987c989@huawei.com> <20170407193156.thwubykqqleaszrt@intel.com> <20170407201037.sarb4mjgfj64hfhr@intel.com> <2f61ea60-6143-3bd4-8b3c-9342625cb326@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <2f61ea60-6143-3bd4-8b3c-9342625cb326-hv44wF8Li93QT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tpmdd-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Roberto Sassu Cc: linux-ima-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: tpmdd-devel@lists.sourceforge.net On Mon, Apr 10, 2017 at 01:51:13PM +0200, Roberto Sassu wrote: > On 4/7/2017 10:10 PM, Jarkko Sakkinen wrote: > > 2. There's a race condition bug in the way Nayna has implemented the > > digest list extension. It takes and releases tpm_mutex multiple times. > > This bug needs to be fixed before any other changes are justified > > (1 commit). Please add the Fixes line to the commit message. > > Isn't tpm_transmit_cmd() called only once? > > Roberto You are correct (sorry Nayna) :-) /Jarkko ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot