From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Sven Van Asbroeck <thesven73@gmail.com>
Cc: thierry.reding@gmail.com, linux-pwm@vger.kernel.org,
linux-kernel@vger.kernel.org, clemens.gruber@pqgruber.com,
andriy.shevchenko@linux.intel.com,
Sven Van Asbroeck <TheSven73@googlemail.com>
Subject: Re: [PATCH v3 1/1] pwm: pca9685: fix gpio-only operation.
Date: Thu, 13 Apr 2017 11:15:55 +0300 [thread overview]
Message-ID: <20170413081555.GC3473@lahna.fi.intel.com> (raw)
In-Reply-To: <1492010159-6050-2-git-send-email-svenv@arcx.com>
On Wed, Apr 12, 2017 at 11:15:59AM -0400, Sven Van Asbroeck wrote:
> + pm_runtime_set_active(&client->dev);
> + /* enable will put the chip into suspend, which is what we
> + * want as all outputs are disabled at this point
> + */
This comment should also be in the standard block comment format.
Other than that, the patch looks good to me.
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
prev parent reply other threads:[~2017-04-13 8:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-12 15:15 [PATCH v3 0/1] pwm: pca9685: fix gpio-only operation Sven Van Asbroeck
2017-04-12 15:15 ` [PATCH v3 1/1] " Sven Van Asbroeck
2017-04-13 8:15 ` Mika Westerberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170413081555.GC3473@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=TheSven73@googlemail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=clemens.gruber@pqgruber.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=thesven73@gmail.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.