From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Thu, 13 Apr 2017 19:52:17 +0000 Subject: [PATCH] drm/i915: checking for NULL instead of IS_ERR() in mock selftests Message-Id: <20170413195217.GA26108@mwanda> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Daniel Vetter , Chris Wilson Cc: dri-devel@lists.freedesktop.org, Arnd Bergmann , Tvrtko Ursulin , intel-gfx@lists.freedesktop.org, Joonas Lahtinen , kernel-janitors@vger.kernel.org, Matthew Auld i915_gem_request_alloc() uses error pointers. It never returns NULLs. Fixes: 0daf0113cff6 ("drm/i915: Mock infrastructure for request emission") Signed-off-by: Dan Carpenter diff --git a/drivers/gpu/drm/i915/selftests/mock_request.c b/drivers/gpu/drm/i915/selftests/mock_request.c index 0e8d2e7f8c70..8097e3693ec4 100644 --- a/drivers/gpu/drm/i915/selftests/mock_request.c +++ b/drivers/gpu/drm/i915/selftests/mock_request.c @@ -35,7 +35,7 @@ mock_request(struct intel_engine_cs *engine, /* NB the i915->requests slab cache is enlarged to fit mock_request */ request = i915_gem_request_alloc(engine, context); - if (!request) + if (IS_ERR(request)) return NULL; mock = container_of(request, typeof(*mock), base); From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: [PATCH] drm/i915: checking for NULL instead of IS_ERR() in mock selftests Date: Thu, 13 Apr 2017 22:52:17 +0300 Message-ID: <20170413195217.GA26108@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter , Chris Wilson Cc: dri-devel@lists.freedesktop.org, Arnd Bergmann , Tvrtko Ursulin , intel-gfx@lists.freedesktop.org, Joonas Lahtinen , kernel-janitors@vger.kernel.org, Matthew Auld List-Id: dri-devel@lists.freedesktop.org aTkxNV9nZW1fcmVxdWVzdF9hbGxvYygpIHVzZXMgZXJyb3IgcG9pbnRlcnMuICBJdCBuZXZlciBy ZXR1cm5zIE5VTExzLgoKRml4ZXM6IDBkYWYwMTEzY2ZmNiAoImRybS9pOTE1OiBNb2NrIGluZnJh c3RydWN0dXJlIGZvciByZXF1ZXN0IGVtaXNzaW9uIikKU2lnbmVkLW9mZi1ieTogRGFuIENhcnBl bnRlciA8ZGFuLmNhcnBlbnRlckBvcmFjbGUuY29tPgoKZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L3NlbGZ0ZXN0cy9tb2NrX3JlcXVlc3QuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L3NlbGZ0ZXN0cy9tb2NrX3JlcXVlc3QuYwppbmRleCAwZThkMmU3ZjhjNzAuLjgwOTdlMzY5M2Vj NCAxMDA2NDQKLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvc2VsZnRlc3RzL21vY2tfcmVxdWVz dC5jCisrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L3NlbGZ0ZXN0cy9tb2NrX3JlcXVlc3QuYwpA QCAtMzUsNyArMzUsNyBAQCBtb2NrX3JlcXVlc3Qoc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5n aW5lLAogCiAJLyogTkIgdGhlIGk5MTUtPnJlcXVlc3RzIHNsYWIgY2FjaGUgaXMgZW5sYXJnZWQg dG8gZml0IG1vY2tfcmVxdWVzdCAqLwogCXJlcXVlc3QgPSBpOTE1X2dlbV9yZXF1ZXN0X2FsbG9j KGVuZ2luZSwgY29udGV4dCk7Ci0JaWYgKCFyZXF1ZXN0KQorCWlmIChJU19FUlIocmVxdWVzdCkp CiAJCXJldHVybiBOVUxMOwogCiAJbW9jayA9IGNvbnRhaW5lcl9vZihyZXF1ZXN0LCB0eXBlb2Yo Km1vY2spLCBiYXNlKTsKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRl dmVsCg==