[rtc-linux] Re: [PATCH v2] x86: i8259: export legacy_pic symbol

[Ingo Molnar <mingo@kernel.org>]

* Alexandre Belloni <alexandre.belloni@free-electrons.com> wrote:

> Hi,
> 
> On 08/04/2017 at 23:03:27 +0200, Hans de Goede wrote:
> > The classic PC rtc-coms driver has a workaround for broken ACPI device
> > nodes for it which lack an irq resource. This workaround used to
> > unconditionally hardcode the irq to 8 in these cases.
> > 
> > This was causing irq conflict problems on systems without a legacy-pic
> > so a recent patch added an if (nr_legacy_irqs()) guard to the
> > workaround to avoid this irq conflict.
> > 
> > nr_legacy_irqs() uses the legacy_pic symbol under the hood causing
> > an undefined symbol error if the rtc-cmos code is build as a module.
> > 
> 
> This is kind of a pressing issue as this makes linux-next fail to build
> for certain configurations.
> 
> I can carry it in my tree with your ack or let you apply it for 4.12.
> What would you prefer?

Unless Thomas objects it looks good to me and feel free to carry it in your tree:

Acked-by: Ingo Molnar <mingo@kernel.org>

Thanks,

	Ingo

-- 
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
--- 
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.