From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Subject: Re: [RFC PATCH v3 0/6] Introduce writeback connectors Date: Fri, 14 Apr 2017 11:35:17 +0200 Message-ID: <20170414113517.323ab297@bbrezillon> References: <1480092544-1725-1-git-send-email-brian.starkey@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail.free-electrons.com (mail.free-electrons.com [62.4.15.54]) by gabe.freedesktop.org (Postfix) with ESMTP id 620D36E060 for ; Fri, 14 Apr 2017 09:35:31 +0000 (UTC) In-Reply-To: <1480092544-1725-1-git-send-email-brian.starkey@arm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Brian Starkey Cc: linux-media@vger.kernel.org, liviu.dudau@arm.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, laurent.pinchart@ideasonboard.com List-Id: dri-devel@lists.freedesktop.org SGkgQnJpYW4sCgpPbiBGcmksIDI1IE5vdiAyMDE2IDE2OjQ4OjU4ICswMDAwCkJyaWFuIFN0YXJr ZXkgPGJyaWFuLnN0YXJrZXlAYXJtLmNvbT4gd3JvdGU6Cgo+IEhpLAo+IAo+IFRoaXMgaXMgdjMg b2YgbXkgc2VyaWVzIGludHJvZHVjaW5nIGEgbmV3IGNvbm5lY3RvciB0eXBlOgo+ICBEUk1fTU9E RV9DT05ORUNUT1JfV1JJVEVCQUNLCj4gU2VlIHYxIGFuZCB2MiBoZXJlOiBbMV0gWzJdCj4gCj4g V3JpdGViYWNrIGNvbm5lY3RvcnMgYXJlIHVzZWQgdG8gZXhwb3NlIHRoZSBtZW1vcnkgd3JpdGVi YWNrIGVuZ2luZXMKPiBmb3VuZCBpbiBzb21lIGRpc3BsYXkgY29udHJvbGxlcnMsIHdoaWNoIGNh biB3cml0ZSBhIENSVEMncwo+IGNvbXBvc2l0aW9uIHJlc3VsdCB0byBhIG1lbW9yeSBidWZmZXIu Cj4gVGhpcyBpcyB1c2VmdWwgZS5nLiBmb3IgdGVzdGluZywgc2NyZWVuLXJlY29yZGluZywgc2Ny ZWVuc2hvdHMsCj4gd2lyZWxlc3MgZGlzcGxheSwgZGlzcGxheSBjbG9uaW5nLCBtZW1vcnktdG8t bWVtb3J5IGNvbXBvc2l0aW9uLgo+IAo+IFdyaXRlYmFjayBjb25uZWN0b3JzIGFyZSBnaXZlbiBh IFdSSVRFQkFDS19GQl9JRCBwcm9wZXJ0eSAod2hpY2ggYWN0cwo+IHNsaWdodGx5IGRpZmZlcmVu dGx5IHRvIEZCX0lELCBzbyBnZXRzIGEgbmV3IG5hbWUpLCBhcyB3ZWxsIGFzCj4gYSBQSVhFTF9G T1JNQVRTIGJsb2IgdG8gbGlzdCB0aGUgc3VwcG9ydGVkIHdyaXRlYmFjayBmb3JtYXRzLCBhbmQK PiBPVVRfRkVOQ0VfUFRSIHRvIGJlIHVzZWQgZm9yIG91dC1mZW5jZXMuCj4gCj4gVGhlIGNoYW5n ZXMgc2luY2UgdjIgYXJlIGluIHRoZSBjb21taXQgbWVzc2FnZXMgb2YgZWFjaCBjb21taXQuCj4g Cj4gVGhlIG1haW4gZGlmZmVyZW5jZXMgYXJlOgo+ICAtIFN1YmNsYXNzIGRybV9jb25uZWN0b3Ig YXMgZHJtX3dyaXRlYmFja19jb25uZWN0b3IKPiAgLSBTbGlnaHQgcmVsYXhhdGlvbiBvZiBjb3Jl IGNoZWNrcywgdG8gYWxsb3cKPiAgICAoY29ubmVjdG9yLT5jcnRjICYmICFjb25uZWN0b3ItPmZi KQo+ICAtIERyb3BwZWQgUElYRUxfRk9STUFUU19TSVpFLCB3aGljaCB3YXMgcmVkdW5kYW50Cj4g IC0gUmV3b3JrZWQgdGhlIGV2ZW50IGludGVyZmFjZSwgZHJpdmVycyBkb24ndCBuZWVkIHRvIGRl YWwgd2l0aCB0aGUKPiAgICBmZW5jZSBkaXJlY3RseQo+ICAtIFJlLW9yZGVyZWQgdGhlIGNvbW1p dHMgdG8gaW50cm9kdWNlIHdyaXRlYmFjayBvdXQtZmVuY2VzIHVwLWZyb250Lgo+IAo+IEkndmUg a2VwdCBSRkMgb24gdGhpcyBzZXJpZXMgYmVjYXVzZSB0aGUgZXZlbnQgcmVwb3J0aW5nIChpbnRy b2R1Y3Rpb24KPiBvZiBkcm1fd3JpdGViYWNrX2pvYikgaXMgcHJvYmFibHkgdXAgZm9yIGRlYmF0 ZS4KPiAKPiB2NCB3aWxsIGJlIGFjY29tcGFuaWVkIGJ5IGlndCB0ZXN0cy4KCkkgcGxhbiB0byBh ZGQgd3JpdGViYWNrIHN1cHBvcnQgdG8gdGhlIFZDNCBkcml2ZXIgYW5kIHdhbnRlZCB0byBrbm93 IGlmCmFueXRoaW5nIGhhcyBjaGFuZ2VkIHNpbmNlIHRoaXMgdjMgKElPVywgZG8geW91IGhhdmUg YSB2NCArIGlndCB0ZXN0cwpyZWFkeSk/Cgo+IAo+IEFzIGFsd2F5cywgSSBsb29rIGZvcndhcmQg dG8gYW55IGNvbW1lbnRzLgoKSSdsbCB0cnkgdG8gcmV2aWV3IHRoZXNlIHBhdGNoZXMuIEtlZXAg aW4gbWluZCB0aGF0IEkgZGlkbid0IGZvbGxvdyB0aGUKaW5pdGlhbCBkaXNjdXNzaW9ucyBhbmQg bWlnaHQgc3VnZ2VzdCB0aGluZ3Mgb3IgYXNrIHF1ZXN0aW9ucyB0aGF0IGhhdmUKYWxyZWFkeSBi ZWVuIGFuc3dlcmVkIGluIHByZXZpb3VzIHZlcnNpb25zIG9mIHRoaXMgc2VyaWVzIG9yIG9uIElS Qy4KClJlZ2FyZHMsCgpCb3JpcwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVz a3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9k cmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail.free-electrons.com ([62.4.15.54]:42762 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751838AbdDNJfc (ORCPT ); Fri, 14 Apr 2017 05:35:32 -0400 Date: Fri, 14 Apr 2017 11:35:17 +0200 From: Boris Brezillon To: Brian Starkey Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, liviu.dudau@arm.com, laurent.pinchart@ideasonboard.com, linux-media@vger.kernel.org Subject: Re: [RFC PATCH v3 0/6] Introduce writeback connectors Message-ID: <20170414113517.323ab297@bbrezillon> In-Reply-To: <1480092544-1725-1-git-send-email-brian.starkey@arm.com> References: <1480092544-1725-1-git-send-email-brian.starkey@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: Hi Brian, On Fri, 25 Nov 2016 16:48:58 +0000 Brian Starkey wrote: > Hi, > > This is v3 of my series introducing a new connector type: > DRM_MODE_CONNECTOR_WRITEBACK > See v1 and v2 here: [1] [2] > > Writeback connectors are used to expose the memory writeback engines > found in some display controllers, which can write a CRTC's > composition result to a memory buffer. > This is useful e.g. for testing, screen-recording, screenshots, > wireless display, display cloning, memory-to-memory composition. > > Writeback connectors are given a WRITEBACK_FB_ID property (which acts > slightly differently to FB_ID, so gets a new name), as well as > a PIXEL_FORMATS blob to list the supported writeback formats, and > OUT_FENCE_PTR to be used for out-fences. > > The changes since v2 are in the commit messages of each commit. > > The main differences are: > - Subclass drm_connector as drm_writeback_connector > - Slight relaxation of core checks, to allow > (connector->crtc && !connector->fb) > - Dropped PIXEL_FORMATS_SIZE, which was redundant > - Reworked the event interface, drivers don't need to deal with the > fence directly > - Re-ordered the commits to introduce writeback out-fences up-front. > > I've kept RFC on this series because the event reporting (introduction > of drm_writeback_job) is probably up for debate. > > v4 will be accompanied by igt tests. I plan to add writeback support to the VC4 driver and wanted to know if anything has changed since this v3 (IOW, do you have a v4 + igt tests ready)? > > As always, I look forward to any comments. I'll try to review these patches. Keep in mind that I didn't follow the initial discussions and might suggest things or ask questions that have already been answered in previous versions of this series or on IRC. Regards, Boris