From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Subject: Re: [PATCH 6/6] drm: mali-dp: Add writeback connector Date: Fri, 14 Apr 2017 11:47:00 +0200 Message-ID: <20170414114700.552acc82@bbrezillon> References: <1480092544-1725-1-git-send-email-brian.starkey@arm.com> <1480092544-1725-7-git-send-email-brian.starkey@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail.free-electrons.com (mail.free-electrons.com [62.4.15.54]) by gabe.freedesktop.org (Postfix) with ESMTP id 9877389DA8 for ; Fri, 14 Apr 2017 09:47:11 +0000 (UTC) In-Reply-To: <1480092544-1725-7-git-send-email-brian.starkey@arm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Brian Starkey Cc: linux-media@vger.kernel.org, liviu.dudau@arm.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, laurent.pinchart@ideasonboard.com List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCAyNSBOb3YgMjAxNiAxNjo0OTowNCArMDAwMApCcmlhbiBTdGFya2V5IDxicmlhbi5z dGFya2V5QGFybS5jb20+IHdyb3RlOgoKPiArc3RhdGljIGludAo+ICttYWxpZHBfbXdfZW5jb2Rl cl9hdG9taWNfY2hlY2soc3RydWN0IGRybV9lbmNvZGVyICplbmNvZGVyLAo+ICsJCQkgICAgICAg c3RydWN0IGRybV9jcnRjX3N0YXRlICpjcnRjX3N0YXRlLAo+ICsJCQkgICAgICAgc3RydWN0IGRy bV9jb25uZWN0b3Jfc3RhdGUgKmNvbm5fc3RhdGUpCj4gK3sKPiArCXN0cnVjdCBtYWxpZHBfbXdf Y29ubmVjdG9yX3N0YXRlICptd19zdGF0ZSA9IHRvX213X3N0YXRlKGNvbm5fc3RhdGUpOwo+ICsJ c3RydWN0IG1hbGlkcF9kcm0gKm1hbGlkcCA9IGVuY29kZXItPmRldi0+ZGV2X3ByaXZhdGU7Cj4g KwlzdHJ1Y3QgZHJtX2ZyYW1lYnVmZmVyICpmYjsKPiArCWludCBpLCBuX3BsYW5lczsKPiArCj4g KwlpZiAoIWNvbm5fc3RhdGUtPndyaXRlYmFja19qb2IgfHwgIWNvbm5fc3RhdGUtPndyaXRlYmFj a19qb2ItPmZiKQo+ICsJCXJldHVybiAwOwo+ICsKPiArCWZiID0gY29ubl9zdGF0ZS0+d3JpdGVi YWNrX2pvYi0+ZmI7Cj4gKwlpZiAoKGZiLT53aWR0aCAhPSBjcnRjX3N0YXRlLT5tb2RlLmhkaXNw bGF5KSB8fAo+ICsJICAgIChmYi0+aGVpZ2h0ICE9IGNydGNfc3RhdGUtPm1vZGUudmRpc3BsYXkp KSB7Cj4gKwkJRFJNX0RFQlVHX0tNUygiSW52YWxpZCBmcmFtZWJ1ZmZlciBzaXplICV1eCV1XG4i LAo+ICsJCQkJZmItPndpZHRoLCBmYi0+aGVpZ2h0KTsKPiArCQlyZXR1cm4gLUVJTlZBTDsKPiAr CX0KClRoZXNlIGNoZWNrcyBsb29rIHByZXR0eSBnZW5lcmljIHRvIG1lLiBTaG91bGRuJ3Qgd2Ug aGF2ZSBhIGRlZmF1bHQKaGVscGVyIGRvaW5nIHRoYXQ/Cgo+ICsKPiArCW13X3N0YXRlLT5mb3Jt YXQgPQo+ICsJCW1hbGlkcF9od19nZXRfZm9ybWF0X2lkKCZtYWxpZHAtPmRldi0+bWFwLCBTRV9N RU1XUklURSwKPiArCQkJCQlmYi0+cGl4ZWxfZm9ybWF0KTsKPiArCWlmIChtd19zdGF0ZS0+Zm9y bWF0ID09IE1BTElEUF9JTlZBTElEX0ZPUk1BVF9JRCkgewoKU2FtZSBnb2VzIGhlcmUuIEJ5IGFk ZGluZyBhIGZvcm1hdF90eXBlcyB0YWJsZSBzaW1pbGFyIHRvIHdoYXQgaXMKZXhwb3NlZCBpbiBk cm1fcGxhbmUgWzFdLCB3ZSBjb3VsZCBkbyB0aGlzIGNoZWNrIGluIHRoZSBjb3JlLiBUaGUgb25s eQp0aGluZyBsZWZ0IHRvIHRoZSBkcml2ZXIgaXMgdGhlIDRDQyAtPiBkcml2ZXItc3BlY2lmaWMt aWQgY29udmVyc2lvbi4KCj4gKwkJc3RydWN0IGRybV9mb3JtYXRfbmFtZV9idWYgZm9ybWF0X25h bWU7Cj4gKwo+ICsJCURSTV9ERUJVR19LTVMoIkludmFsaWQgcGl4ZWwgZm9ybWF0ICVzXG4iLAo+ ICsJCQkgICAgICBkcm1fZ2V0X2Zvcm1hdF9uYW1lKGZiLT5waXhlbF9mb3JtYXQsICZmb3JtYXRf bmFtZSkpOwo+ICsJCXJldHVybiAtRUlOVkFMOwo+ICsJfQo+ICsKPiArCW5fcGxhbmVzID0gZHJt X2Zvcm1hdF9udW1fcGxhbmVzKGZiLT5waXhlbF9mb3JtYXQpOwo+ICsJZm9yIChpID0gMDsgaSA8 IG5fcGxhbmVzOyBpKyspIHsKPiArCQlzdHJ1Y3QgZHJtX2dlbV9jbWFfb2JqZWN0ICpvYmogPSBk cm1fZmJfY21hX2dldF9nZW1fb2JqKGZiLCBpKTsKPiArCQlpZiAoIW1hbGlkcF9od19waXRjaF92 YWxpZChtYWxpZHAtPmRldiwgZmItPnBpdGNoZXNbaV0pKSB7Cj4gKwkJCURSTV9ERUJVR19LTVMo IkludmFsaWQgcGl0Y2ggJXUgZm9yIHBsYW5lICVkXG4iLAo+ICsJCQkJICAgICAgZmItPnBpdGNo ZXNbaV0sIGkpOwo+ICsJCQlyZXR1cm4gLUVJTlZBTDsKPiArCQl9Cj4gKwkJbXdfc3RhdGUtPnBp dGNoZXNbaV0gPSBmYi0+cGl0Y2hlc1tpXTsKPiArCQltd19zdGF0ZS0+YWRkcnNbaV0gPSBvYmot PnBhZGRyICsgZmItPm9mZnNldHNbaV07Cj4gKwl9Cj4gKwltd19zdGF0ZS0+bl9wbGFuZXMgPSBu X3BsYW5lczsKPiArCj4gKwlyZXR1cm4gMDsKPiArfQoKClsxXWh0dHA6Ly9seHIuZnJlZS1lbGVj dHJvbnMuY29tL3NvdXJjZS9pbmNsdWRlL2RybS9kcm1fcGxhbmUuaCNMNDgyCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxp c3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNr dG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail.free-electrons.com ([62.4.15.54]:42862 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751905AbdDNJrM (ORCPT ); Fri, 14 Apr 2017 05:47:12 -0400 Date: Fri, 14 Apr 2017 11:47:00 +0200 From: Boris Brezillon To: Brian Starkey Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, liviu.dudau@arm.com, laurent.pinchart@ideasonboard.com, linux-media@vger.kernel.org Subject: Re: [PATCH 6/6] drm: mali-dp: Add writeback connector Message-ID: <20170414114700.552acc82@bbrezillon> In-Reply-To: <1480092544-1725-7-git-send-email-brian.starkey@arm.com> References: <1480092544-1725-1-git-send-email-brian.starkey@arm.com> <1480092544-1725-7-git-send-email-brian.starkey@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: On Fri, 25 Nov 2016 16:49:04 +0000 Brian Starkey wrote: > +static int > +malidp_mw_encoder_atomic_check(struct drm_encoder *encoder, > + struct drm_crtc_state *crtc_state, > + struct drm_connector_state *conn_state) > +{ > + struct malidp_mw_connector_state *mw_state = to_mw_state(conn_state); > + struct malidp_drm *malidp = encoder->dev->dev_private; > + struct drm_framebuffer *fb; > + int i, n_planes; > + > + if (!conn_state->writeback_job || !conn_state->writeback_job->fb) > + return 0; > + > + fb = conn_state->writeback_job->fb; > + if ((fb->width != crtc_state->mode.hdisplay) || > + (fb->height != crtc_state->mode.vdisplay)) { > + DRM_DEBUG_KMS("Invalid framebuffer size %ux%u\n", > + fb->width, fb->height); > + return -EINVAL; > + } These checks look pretty generic to me. Shouldn't we have a default helper doing that? > + > + mw_state->format = > + malidp_hw_get_format_id(&malidp->dev->map, SE_MEMWRITE, > + fb->pixel_format); > + if (mw_state->format == MALIDP_INVALID_FORMAT_ID) { Same goes here. By adding a format_types table similar to what is exposed in drm_plane [1], we could do this check in the core. The only thing left to the driver is the 4CC -> driver-specific-id conversion. > + struct drm_format_name_buf format_name; > + > + DRM_DEBUG_KMS("Invalid pixel format %s\n", > + drm_get_format_name(fb->pixel_format, &format_name)); > + return -EINVAL; > + } > + > + n_planes = drm_format_num_planes(fb->pixel_format); > + for (i = 0; i < n_planes; i++) { > + struct drm_gem_cma_object *obj = drm_fb_cma_get_gem_obj(fb, i); > + if (!malidp_hw_pitch_valid(malidp->dev, fb->pitches[i])) { > + DRM_DEBUG_KMS("Invalid pitch %u for plane %d\n", > + fb->pitches[i], i); > + return -EINVAL; > + } > + mw_state->pitches[i] = fb->pitches[i]; > + mw_state->addrs[i] = obj->paddr + fb->offsets[i]; > + } > + mw_state->n_planes = n_planes; > + > + return 0; > +} [1]http://lxr.free-electrons.com/source/include/drm/drm_plane.h#L482