From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jerin Jacob Subject: Re: [PATCH 1/2] net/thunderx: add empty link up/down callbacks Date: Fri, 14 Apr 2017 18:07:56 +0530 Message-ID: <20170414123754.GA16532@jerin> References: <1490968669-9161-1-git-send-email-Andriy.Berestovskyy@caviumnetworks.com> <20170403151315.2yrchyh4fgpjn3ha@localhost.localdomain> <49a27795-e6b8-7510-beda-2eb4c533b874@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Andriy Berestovskyy , Maciej Czekaj , dev@dpdk.org To: Ferruh Yigit Return-path: Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0054.outbound.protection.outlook.com [104.47.36.54]) by dpdk.org (Postfix) with ESMTP id D409629D6 for ; Fri, 14 Apr 2017 14:38:22 +0200 (CEST) Content-Disposition: inline In-Reply-To: <49a27795-e6b8-7510-beda-2eb4c533b874@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" -----Original Message----- > Date: Thu, 13 Apr 2017 12:04:51 +0100 > From: Ferruh Yigit > To: Jerin Jacob , Andriy Berestovskyy > > CC: Maciej Czekaj , dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 1/2] net/thunderx: add empty link up/down > callbacks > User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 > Thunderbird/52.0 > > On 4/3/2017 4:13 PM, Jerin Jacob wrote: > > On Fri, Mar 31, 2017 at 03:57:48PM +0200, Andriy Berestovskyy wrote: > >> Some applications and DPDK examples expect link up/down > >> functionality to be provided. > >> > >> Signed-off-by: Andriy Berestovskyy > >> --- > >> drivers/net/thunderx/nicvf_ethdev.c | 14 ++++++++++++++ > >> 1 file changed, 14 insertions(+) > >> > >> diff --git a/drivers/net/thunderx/nicvf_ethdev.c b/drivers/net/thunderx/nicvf_ethdev.c > >> index 1060319..984c218 100644 > >> --- a/drivers/net/thunderx/nicvf_ethdev.c > >> +++ b/drivers/net/thunderx/nicvf_ethdev.c > >> @@ -1924,11 +1924,25 @@ nicvf_dev_configure(struct rte_eth_dev *dev) > >> return 0; > >> } > >> > >> +static int > >> +nicvf_dev_set_link_up(struct rte_eth_dev *dev __rte_unused) > >> +{ > >> + return 0; > >> +} > >> + > >> +static int > >> +nicvf_dev_set_link_down(struct rte_eth_dev *dev __rte_unused) > >> +{ > >> + return 0; > >> +} > > > > > > Since the VF drivers can't really initiate link_up and link_down and > > other VF drivers like i40e VF is not setting this callback. I think, it is > > OK keep it as -ENOSUP(which is default). > > > > Since Christain Acked on the fix on the usage of examples/ip_pipeline > > application. Probably we are OK without this change. > > Any update planned to this patch? Should I update this as nack? > You can mark as "Not applicable" in patchwork. Thanks > > > > http://dpdk.org/ml/archives/dev/2017-March/062704.html > > > > Any thought from ethdev maintainers? > > > >> + > >> /* Initialize and register driver with DPDK Application */ > >> static const struct eth_dev_ops nicvf_eth_dev_ops = { > >> .dev_configure = nicvf_dev_configure, > >> .dev_start = nicvf_dev_start, > >> .dev_stop = nicvf_dev_stop, > >> + .dev_set_link_up = nicvf_dev_set_link_up, > >> + .dev_set_link_down = nicvf_dev_set_link_down, > >> .link_update = nicvf_dev_link_update, > >> .dev_close = nicvf_dev_close, > >> .stats_get = nicvf_dev_stats_get, > >> -- > >> 2.7.4 > >> >