From: Stephen Hemminger <stephen@networkplumber.org>
To: David Ahern <dsa@cumulusnetworks.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH iproute2] ip vrf: Add command name next to pid
Date: Fri, 14 Apr 2017 15:57:37 -0700 [thread overview]
Message-ID: <20170414155737.24d3ce38@xeon-e3> (raw)
In-Reply-To: <1492048452-9052-1-git-send-email-dsa@cumulusnetworks.com>
Overall, this looks like a good idea.
> +
> +int get_comm(char *pid, char *comm, int len)
Please use more glibc style function signature, like:
int get_comm(const char *pid, char *comm, size_t len)
And maybe even
int get_command_name(pid_t pid, char *comm, size_t len)
next prev parent reply other threads:[~2017-04-14 22:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-13 1:54 [PATCH iproute2] ip vrf: Add command name next to pid David Ahern
2017-04-14 22:57 ` Stephen Hemminger [this message]
2017-04-14 23:07 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170414155737.24d3ce38@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=dsa@cumulusnetworks.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.