From: Matthias Kaehlcke <mka@chromium.org>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: linux-kbuild@vger.kernel.org, David Howells <dhowells@redhat.com>,
Michael Davidson <md@google.com>, Michal Marek <mmarek@suse.com>,
Jan Beulich <JBeulich@novell.com>,
Alexander van Heukelum <heukelum@fastmail.fm>,
Jeroen Hofstee <jeroen@myspectrum.nl>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] kbuild: fix asm-offset generation to work with clang
Date: Fri, 14 Apr 2017 10:44:58 -0700 [thread overview]
Message-ID: <20170414174458.GL28657@google.com> (raw)
In-Reply-To: <1492149003-19136-3-git-send-email-yamada.masahiro@socionext.com>
El Fri, Apr 14, 2017 at 02:50:03PM +0900 Masahiro Yamada ha dit:
> From: Jeroen Hofstee <jeroen@myspectrum.nl>
>
> KBuild abuses the asm statement to write to a file and
> clang chokes about these invalid asm statements. Hack it
> even more by fooling this is actual valid asm code.
>
> Signed-off-by: Jeroen Hofstee <jeroen@myspectrum.nl>
> [masahiro:
> Import Jeroen's work for U-Boot:
> http://patchwork.ozlabs.org/patch/375026/
> Tweak sed script a little to drop garbage '#' for GCC case, like
> #define NR_PAGEFLAGS 23 /* __NR_PAGEFLAGS # */ ]
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
Tested-by: Matthias Kaehlcke <mka@chromium.org>
I tested with x86 and arm64. Please note that two more changes are
needed to avoid breaking frv and um:
https://patchwork.kernel.org/patch/9660473/
https://patchwork.kernel.org/patch/9660503/
Maybe these should be part of your patch set? I only sent them out
separately to avoid cross posting with my initial patch for this issue
being a RFC.
Cheers
Matthias
prev parent reply other threads:[~2017-04-14 17:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-14 5:50 [PATCH 0/2] kbuild: cleanup asm-offset generation, and make it work with clang Masahiro Yamada
2017-04-14 5:50 ` [PATCH 1/2] kbuild: consolidate redundant sed script ASM offset generation Masahiro Yamada
2017-04-14 16:51 ` Matthias Kaehlcke
2017-04-18 9:57 ` David Howells
2017-04-18 10:20 ` Masahiro Yamada
2017-04-18 13:15 ` David Howells
2017-04-18 14:03 ` Masahiro Yamada
2017-04-14 5:50 ` [PATCH 2/2] kbuild: fix asm-offset generation to work with clang Masahiro Yamada
2017-04-14 17:44 ` Matthias Kaehlcke [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170414174458.GL28657@google.com \
--to=mka@chromium.org \
--cc=JBeulich@novell.com \
--cc=dhowells@redhat.com \
--cc=heukelum@fastmail.fm \
--cc=jeroen@myspectrum.nl \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=md@google.com \
--cc=mmarek@suse.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.