From: Pablo Neira Ayuso <pablo@netfilter.org>
To: gfree.wind@foxmail.com
Cc: netfilter-devel@vger.kernel.org, Gao Feng <fgao@ikuai8.com>
Subject: Re: [PATCH nf-next 1/1] netfilter: ecache: Refine the nf_ct_deliver_cached_events
Date: Sat, 15 Apr 2017 11:29:09 +0200 [thread overview]
Message-ID: <20170415092909.GA5278@salvia> (raw)
In-Reply-To: <1492047349-99130-1-git-send-email-gfree.wind@foxmail.com>
On Thu, Apr 13, 2017 at 09:35:49AM +0800, gfree.wind@foxmail.com wrote:
> From: Gao Feng <fgao@ikuai8.com>
>
> 1. Remove single !events condition check to deliver the missed event
> even though there is no new event happened.
>
> Consider this case:
> 1) nf_ct_deliver_cached_events is invoked at the first time, the
> event is failed to deliver, then the missed is set.
> 2) nf_ct_deliver_cached_events is invoked again, but there is no
> any new event happened.
> The missed event is lost really.
>
> It would try to send the missed event again after remove this check.
> And it is ok if there is no missed event because the latter check
> !((events | missed) & e->ctmask) could avoid it.
>
> 2. Correct the return value check of notify->fcn.
> When send the event successfully, it returns 0, not postive value.
Applied, thanks.
prev parent reply other threads:[~2017-04-15 9:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-13 1:35 [PATCH nf-next 1/1] netfilter: ecache: Refine the nf_ct_deliver_cached_events gfree.wind
2017-04-15 9:29 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170415092909.GA5278@salvia \
--to=pablo@netfilter.org \
--cc=fgao@ikuai8.com \
--cc=gfree.wind@foxmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.