All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Lee Jones <lee.jones@linaro.org>, Samuel Ortiz <sameo@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
	Felipe Balbi <felipe.balbi@linux.intel.com>,
	Keshava Munegowda <keshava_mgowda@ti.com>,
	Marcel Partap <mpartap@gmx.net>,
	Michael Scott <michael.scott@linaro.org>,
	Roger Quadros <rogerq@ti.com>, Sebastian Reichel <sre@kernel.org>
Subject: [PATCH 1/2] mfd: omap-usb-tll: Fix inverted bit use for USB TLL mode
Date: Sat, 15 Apr 2017 10:05:08 -0700	[thread overview]
Message-ID: <20170415170509.17364-2-tony@atomide.com> (raw)
In-Reply-To: <20170415170509.17364-1-tony@atomide.com>

Commit 16fa3dc75c22 ("mfd: omap-usb-tll: HOST TLL platform driver")
added support for USB TLL, but uses OMAP_TLL_CHANNEL_CONF_ULPINOBITSTUFF
bit the wrong way. The comments in the code are correct, but the inverted
use of OMAP_TLL_CHANNEL_CONF_ULPINOBITSTUFF causes the register to be
enabled instead of disabled unlike what the comments say.

Without this change the Wrigley 3G LTE modem on droid 4 EHCI bus can
be only pinged few times before it stops responding.

Fixes: 16fa3dc75c22 ("mfd: omap-usb-tll: HOST TLL platform driver")
Cc: Felipe Balbi <felipe.balbi@linux.intel.com>
Cc: Keshava Munegowda <keshava_mgowda@ti.com>
Cc: Marcel Partap <mpartap@gmx.net>
Cc: Michael Scott <michael.scott@linaro.org>
Cc: Roger Quadros <rogerq@ti.com>
Cc: Sebastian Reichel <sre@kernel.org>
Signed-off-by: Tony Lindgren <tony@atomide.com>
---
 drivers/mfd/omap-usb-tll.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mfd/omap-usb-tll.c b/drivers/mfd/omap-usb-tll.c
--- a/drivers/mfd/omap-usb-tll.c
+++ b/drivers/mfd/omap-usb-tll.c
@@ -377,8 +377,8 @@ int omap_tll_init(struct usbhs_omap_platform_data *pdata)
 				 * and use SDR Mode
 				 */
 				reg &= ~(OMAP_TLL_CHANNEL_CONF_UTMIAUTOIDLE
-					| OMAP_TLL_CHANNEL_CONF_ULPINOBITSTUFF
 					| OMAP_TLL_CHANNEL_CONF_ULPIDDRMODE);
+				reg |= OMAP_TLL_CHANNEL_CONF_ULPINOBITSTUFF;
 			} else if (pdata->port_mode[i] ==
 					OMAP_EHCI_PORT_MODE_HSIC) {
 				/*
-- 
2.12.2

  reply	other threads:[~2017-04-15 17:05 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-15 17:05 [PATCHv2 0/2] mfd: omap-usb-tll: Fixes for USB TLL mode Tony Lindgren
2017-04-15 17:05 ` Tony Lindgren [this message]
2017-04-18  8:30   ` [PATCH 1/2] mfd: omap-usb-tll: Fix inverted bit use " Roger Quadros
2017-04-18  8:30     ` Roger Quadros
2017-04-24 11:40   ` Lee Jones
2017-04-15 17:05 ` [PATCH 2/2] mfd: omap-usb-tll: Configure ULPIAUTOIDLE Tony Lindgren
2017-04-18  8:31   ` Roger Quadros
2017-04-18  8:31     ` Roger Quadros
2017-04-24 11:41   ` Lee Jones
2017-04-24 11:43 ` [PATCHv2 0/2] mfd: omap-usb-tll: Fixes for USB TLL mode Lee Jones
2017-04-24 14:15   ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170415170509.17364-2-tony@atomide.com \
    --to=tony@atomide.com \
    --cc=felipe.balbi@linux.intel.com \
    --cc=keshava_mgowda@ti.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=michael.scott@linaro.org \
    --cc=mpartap@gmx.net \
    --cc=rogerq@ti.com \
    --cc=sameo@linux.intel.com \
    --cc=sre@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.