From: Stephen Hemminger <stephen@networkplumber.org>
To: David Lebrun <david.lebrun@uclouvain.be>
Cc: <netdev@vger.kernel.org>
Subject: Re: [PATCH iproute2 net-next v2 1/3] ip: add ip sr command to control SR-IPv6 internal structures
Date: Sun, 16 Apr 2017 10:22:27 -0700 [thread overview]
Message-ID: <20170416102227.2356400e@xeon-e3> (raw)
In-Reply-To: <20170415101717.18730-2-david.lebrun@uclouvain.be>
Overall, this looks fine and applied.
I had to add seg6.h to include/linux since it was not there.
> + switch (alg_id) {
> + case SEG6_HMAC_ALGO_SHA1:
> + algstr = "sha1";
> + break;
> + case SEG6_HMAC_ALGO_SHA256:
> + algstr = "sha256";
> + break;
> + default:
> + algstr = "<unknown>";
> + }
You might want to consider having a table of HMAC algorithms so that get and set match.
It seems likely that new values will come.
next prev parent reply other threads:[~2017-04-16 17:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-15 10:17 [PATCH iproute2 net-next v2 0/3] Add support for IPv6 Segment Routing David Lebrun
2017-04-15 10:17 ` [PATCH iproute2 net-next v2 1/3] ip: add ip sr command to control SR-IPv6 internal structures David Lebrun
2017-04-16 17:22 ` Stephen Hemminger [this message]
2017-04-15 10:17 ` [PATCH iproute2 net-next v2 2/3] iproute: add support for SR-IPv6 lwtunnel encapsulation David Lebrun
2017-04-15 10:17 ` [PATCH iproute2 net-next v2 3/3] man: add documentation for IPv6 SR commands David Lebrun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170416102227.2356400e@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=david.lebrun@uclouvain.be \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.