From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932469AbdDRIeC (ORCPT ); Tue, 18 Apr 2017 04:34:02 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:39569 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932190AbdDRId5 (ORCPT ); Tue, 18 Apr 2017 04:33:57 -0400 X-ME-Sender: X-Sasl-enc: TLYqr8jZKxot/YIcK4nldPoiDXEvDD2NIKpXyCfDNMVx 1492504435 Date: Tue, 18 Apr 2017 10:33:48 +0200 From: Greg KH To: Chewie Lin Cc: forest@alittletooquiet.net, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] drivers/staging/vt6656/main_usb.c: usb_device_reset Message-ID: <20170418083348.GA4366@kroah.com> References: <20170418082437.25451-1-linsh@oregonstate.edu> <20170418082437.25451-2-linsh@oregonstate.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170418082437.25451-2-linsh@oregonstate.edu> User-Agent: Mutt/1.8.1 (2017-04-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 18, 2017 at 01:24:37AM -0700, Chewie Lin wrote: > Removed the usb_device_reset(), replace with call to usb_reset_device() > directly. Plus it removes the confusing function name and addressed > the checkpatch warning as well by swap string in the dev_warn() call with > __func__ argument, instead of explicitly calling the function name in > the string: > > WARNING: Prefer using "%s", __func__ to embedded function names > #417: FILE: main_usb.c:417: > + "usb_device_reset fail status=%d\n", status); > > total: 0 errors, 1 warnings, 1058 lines checked > > And after fix: > > main_usb.c has no obvious style problems and is ready for submission. > > > Signed-off-by: Chewie Lin Your subject line is odd, don't you think? Compare it to other patches for this driver and please fix it up and resend. And there's never a need for a 0/X email for a single patch submission, no need to do that again. thanks, greg k-h