From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olaf Hering Subject: Re: [PATCH RFC] handle tsc_tolerance during migration between identical hosts Date: Tue, 18 Apr 2017 11:50:01 +0200 Message-ID: <20170418095001.GA15953@aepfle.de> References: <20170411093938.GA25549@aepfle.de> <58ECC547020000780014FCCC@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5284306926341764898==" Return-path: In-Reply-To: <58ECC547020000780014FCCC@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Jan Beulich Cc: xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org --===============5284306926341764898== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="AhhlLboLdkugWU4S" Content-Disposition: inline --AhhlLboLdkugWU4S Content-Type: text/plain; charset=utf-8 Content-Disposition: inline On Tue, Apr 11, Jan Beulich wrote: > I'm afraid successful testing is not a sufficient criteria here. At > the very least the (so far missing) documentation needs to very > clearly point out the possible risks associated with using this > option. But with there not being any functional change when > the option is not being made use of, I don't think there's a > reason not to add this (for the adventurous). This can be handled by refering to the documentation of 'tsc_mode=native', which is what this change actually does. > What I'm not sure about is whether having this as a global > (instead of per-guest) setting is really all that useful: As > different guests may require different tolerance, having a > single unique setting may not allow people to get very far. Another change on top of this, which adds a per-domU knob, could be added. This also requires a decision if the per-domU or the global knob has higher priority. > > also on the name of the cmdline option? > I'm trying to advocate for dashes instead of underscores, and > I think it should say vtsc instead of tsc, to make clear it has an > effect on guests only. I will use "vtsc-tolerance=$khz". Olaf --AhhlLboLdkugWU4S Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EARECAB0WIQSkRyP6Rn//f03pRUBdQqD6ppg2fgUCWPXhRgAKCRBdQqD6ppg2 fv4OAJ40QuMtVYJ8MtinARHrFF93dsItTgCcDLGElFhuE4ntXani6U/GhFP9kM0= =gWK9 -----END PGP SIGNATURE----- --AhhlLboLdkugWU4S-- --===============5284306926341764898== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v cmcveGVuLWRldmVsCg== --===============5284306926341764898==--