From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Fleming Subject: Re: [PATCH 5/8] efi/capsule-loader: use cached copy of capsule header Date: Tue, 18 Apr 2017 13:34:26 +0100 Message-ID: <20170418123426.GF24360@codeblueprint.co.uk> References: <20170405092317.27921-1-ard.biesheuvel@linaro.org> <20170405092317.27921-6-ard.biesheuvel@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20170405092317.27921-6-ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> Sender: linux-efi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Ard Biesheuvel Cc: linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, andy.shevchenko-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, pure.logic-SyKdqv6vbfZdzvEItQ6vdLNAH6kLmebB@public.gmane.org, hock.leong.kweh-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org, sascha.weisenberger-kv7WeFo6aLtBDgjK7y7TUQ@public.gmane.org, jan.kiszka-kv7WeFo6aLtBDgjK7y7TUQ@public.gmane.org List-Id: linux-efi@vger.kernel.org On Wed, 05 Apr, at 10:23:14AM, Ard Biesheuvel wrote: > Instead of kmapping the capsule data twice, copy the capsule header > into the capsule info struct we keep locally. This is an improvement > by itself, but will also enable handling of non-standard header formats > more easily. > > Signed-off-by: Ard Biesheuvel > --- > drivers/firmware/efi/capsule-loader.c | 41 ++++++++------------ > 1 file changed, 17 insertions(+), 24 deletions(-) Reviewed-by: Matt Fleming