From: Sowmini Varadhan <sowmini.varadhan@oracle.com>
To: Mike Maloney <maloneykernel@gmail.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
Mike Maloney <maloney@google.com>
Subject: Re: [PATCH net] selftests/net: Fixes psock_fanout CBPF test case
Date: Tue, 18 Apr 2017 11:26:16 -0400 [thread overview]
Message-ID: <20170418152616.GE18699@oracle.com> (raw)
In-Reply-To: <20170418151416.17858-1-maloneykernel@gmail.com>
On (04/18/17 11:14), Mike Maloney wrote:
> Change 'psock_fanout' to use SOCK_RAW so that the CBPF program used with
> SO_ATTACH_FILTER can examine the entire frame. Create a new CBPF
> program for use with PACKET_FANOUT_DATA which ignores the header, as it
> cannot see the ethernet header.
Fix look good to me, but could you please also add the bpf_asm input
as a comment to the C code, in case we want to to read/extend this
down the road?
--Sowmini
next prev parent reply other threads:[~2017-04-18 15:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-18 15:14 [PATCH net] selftests/net: Fixes psock_fanout CBPF test case Mike Maloney
2017-04-18 15:26 ` Sowmini Varadhan [this message]
2017-04-18 15:56 ` Mike Maloney
2017-04-18 17:03 ` Sowmini Varadhan
2017-04-20 19:39 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170418152616.GE18699@oracle.com \
--to=sowmini.varadhan@oracle.com \
--cc=davem@davemloft.net \
--cc=maloney@google.com \
--cc=maloneykernel@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.