From: Christoph Hellwig <hch@lst.de>
To: Bart Van Assche <bart.vanassche@sandisk.com>
Cc: "Jens Axboe" <axboe@kernel.dk>,
linux-block@vger.kernel.org, "Christoph Hellwig" <hch@lst.de>,
"Matias Bjørling" <m@bjorling.me>,
"Adam Manzanares" <adam.manzanares@wdc.com>
Subject: Re: [PATCH 2/5] null_blk: Use blk_init_request_from_bio() instead of open-coding it
Date: Wed, 19 Apr 2017 08:18:57 +0200 [thread overview]
Message-ID: <20170419061857.GB6412@lst.de> (raw)
In-Reply-To: <20170418231037.3968-3-bart.vanassche@sandisk.com>
Looks fine,
Reviewed-by: Christoph Hellwig <hch@lst.de>
Although I wonder why the nvme lighnvm support cares about
a NULL-bio the null_blk one does not?
next prev parent reply other threads:[~2017-04-19 6:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-18 23:10 [PATCH 0/5] Reduce code duplication Bart Van Assche
2017-04-18 23:10 ` [PATCH 1/5] block: Export blk_init_request_from_bio() Bart Van Assche
2017-04-19 6:16 ` Christoph Hellwig
2017-04-18 23:10 ` [PATCH 2/5] null_blk: Use blk_init_request_from_bio() instead of open-coding it Bart Van Assche
2017-04-19 6:18 ` Christoph Hellwig [this message]
2017-04-18 23:10 ` [PATCH 3/5] lightnvm: " Bart Van Assche
2017-04-19 6:19 ` Christoph Hellwig
2017-04-18 23:10 ` [PATCH 4/5] block: Inline blk_rq_set_prio() Bart Van Assche
2017-04-19 6:20 ` Christoph Hellwig
2017-04-19 14:38 ` Jens Axboe
2017-04-19 15:54 ` Bart Van Assche
2017-04-18 23:10 ` [PATCH 5/5] block: Optimize ioprio_best() Bart Van Assche
2017-04-19 6:21 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170419061857.GB6412@lst.de \
--to=hch@lst.de \
--cc=adam.manzanares@wdc.com \
--cc=axboe@kernel.dk \
--cc=bart.vanassche@sandisk.com \
--cc=linux-block@vger.kernel.org \
--cc=m@bjorling.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.