From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: "Tan, Jianfeng" <jianfeng.tan@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"olivier.matz@6wind.com" <olivier.matz@6wind.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [PATCH v2] net/virtio-user: fix not working on 32-bit system
Date: Wed, 19 Apr 2017 14:24:03 +0800 [thread overview]
Message-ID: <20170419062403.GC31523@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <ED26CBA2FAD1BF48A8719AEF02201E36511A4A0F@SHSMSX103.ccr.corp.intel.com>
On Wed, Apr 19, 2017 at 06:21:59AM +0000, Tan, Jianfeng wrote:
>
>
> > I've expected it to be plain english, something like following:
> >
> > /*
> > * Return the physical address (or virtual address in case of
> > * virtio-user) of mbuf data buffer.
> > *
> > * The address is firstly casted to the word size (sizeof(uintptr_t))
> > * before casting it to uint64_t. This is to make it work with different
> > * combination of word size (64 bit and 32 bit) and virtio device
> > * (virtio-pci and virtio-user).
> > */
> >
> > Okay to you?
>
> Yep, sounds better. Thanks!
Good. Applied to dpdk-next-virtio, with above change.
Thanks.
--yliu
next prev parent reply other threads:[~2017-04-19 6:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-13 14:12 [PATCH] net/virtio-user: fix not working on 32-bit system Jianfeng Tan
2017-04-14 5:32 ` Yuanhan Liu
2017-04-14 5:53 ` Tan, Jianfeng
2017-04-14 6:20 ` Yuanhan Liu
2017-04-14 6:56 ` Tan, Jianfeng
2017-04-14 7:01 ` Yuanhan Liu
2017-04-14 7:14 ` Tan, Jianfeng
2017-04-19 2:30 ` [PATCH v2] " Jianfeng Tan
2017-04-19 5:53 ` Yuanhan Liu
2017-04-19 6:21 ` Tan, Jianfeng
2017-04-19 6:24 ` Yuanhan Liu [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-09-19 22:24 Jim Murphy
2017-09-20 2:17 ` Tan, Jianfeng
2017-09-20 2:55 ` Jim Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170419062403.GC31523@yliu-dev.sh.intel.com \
--to=yuanhan.liu@linux.intel.com \
--cc=dev@dpdk.org \
--cc=jianfeng.tan@intel.com \
--cc=olivier.matz@6wind.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.