From: Wolfram Sang <wsa@the-dreams.de>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
linux-i2c@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
Kuninori Morimoto <kuninori.morimoto.gx@gmail.com>,
Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: [PATCH] i2c: rcar: fix resume by always initializing registers before transfer
Date: Wed, 19 Apr 2017 08:59:28 +0200 [thread overview]
Message-ID: <20170419065928.GC1432@katana> (raw)
In-Reply-To: <87o9vtl19p.wl%kuninori.morimoto.gx@renesas.com>
[-- Attachment #1: Type: text/plain, Size: 767 bytes --]
Morimoto-san,
> I understand about I2C slave / multi-master case of pm_runtime_get/put.
> But in probe case (after rcar_i2c_init() move), we can't do like below ?
> this is more clear code for me.
>
> -------------
> diff --git a/drivers/i2c/busses/i2c-rcar.c b/drivers/i2c/busses/i2c-rcar.c
> index 26f2ff2..db7f4d1 100644
> --- a/drivers/i2c/busses/i2c-rcar.c
> +++ b/drivers/i2c/busses/i2c-rcar.c
> @@ -855,7 +855,6 @@ static int rcar_i2c_probe(struct platform_device *pdev)
> priv->dma_rx = priv->dma_tx = ERR_PTR(-EPROBE_DEFER);
>
> pm_runtime_enable(dev);
> - pm_runtime_get_sync(dev);
> ret = rcar_i2c_clock_calculate(priv, &i2c_t);
rcar_i2c_clock_calculate() uses clk_get_rate, so clk must be active.
Regards,
Wolfram
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2017-04-19 6:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-18 18:38 [PATCH] i2c: rcar: fix resume by always initializing registers before transfer Wolfram Sang
2017-04-18 23:59 ` Kuninori Morimoto
2017-04-18 23:59 ` Kuninori Morimoto
2017-04-19 6:59 ` Wolfram Sang [this message]
2017-04-19 7:29 ` Kuninori Morimoto
2017-04-19 7:29 ` Kuninori Morimoto
2017-04-22 6:16 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170419065928.GC1432@katana \
--to=wsa@the-dreams.de \
--cc=geert@linux-m68k.org \
--cc=kuninori.morimoto.gx@gmail.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.