All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eryu Guan <eguan@redhat.com>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Miklos Szeredi <miklos@szeredi.hu>,
	Trond Myklebust <trondmy@primarydata.com>,
	Jeff Layton <jlayton@poochiereds.net>,
	"J . Bruce Fields" <bfields@fieldses.org>,
	fstests <fstests@vger.kernel.org>,
	linux-unionfs@vger.kernel.org
Subject: Re: [PATCH 4/4] fstests: add generic test for file handles
Date: Wed, 19 Apr 2017 18:41:42 +0800	[thread overview]
Message-ID: <20170419104142.GW8951@eguan.usersys.redhat.com> (raw)
In-Reply-To: <CAOQ4uxhngqyVR20iT+0-4jyk_e9VXgP7zsSQp3tuN=c_A-MYaA@mail.gmail.com>

On Wed, Apr 19, 2017 at 01:07:47PM +0300, Amir Goldstein wrote:
...
> > So how about remove all the files and call "open_by_handle -c ..."
> > before each test? e.g. (I use testdir and don't remove lost+found dir
> > because extN needs it for fsck)
> >
> 
> Sure. Makes sense.
> Going forward, as you might have guessed, I am going to add
> _scratch_cycle_mount to the mix.
> 
> 
> > testdir=$SCRATCH_MNT/testdir
> 
> So I copied using SCRATCH_MNT from xfs/238, but I wonder if
> I should go with thsi instead:
> testdir=$TEST_DIR/$seq
> 
> Maybe some fs is vulnerable to exporting handles from an ages fs
> who knows... Any opinion?

Hmm, I have no strong preference on this, seems TEST_DIR should be
sufficient for the test and we can get rid of one test requirement.

Thanks,
Eryu

      reply	other threads:[~2017-04-19 10:41 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-18 18:17 [PATCH 0/4] fstests: generic test for NFS handles Amir Goldstein
2017-04-18 18:17 ` [PATCH 1/4] src/open_by_handle: helper to test open_by_handle_at() syscall Amir Goldstein
2017-04-18 18:55   ` J . Bruce Fields
2017-04-18 19:13     ` Amir Goldstein
2017-04-18 19:33       ` J . Bruce Fields
2017-04-19  8:53   ` Eryu Guan
2017-04-19  9:51   ` David Howells
2017-04-19 10:08     ` Amir Goldstein
2017-04-18 18:17 ` [PATCH 2/4] src/open_by_handle: flexible usage options Amir Goldstein
2017-04-18 19:14   ` J . Bruce Fields
2017-04-18 19:22     ` Amir Goldstein
2017-04-18 19:35       ` J . Bruce Fields
2017-04-19  9:42   ` Eryu Guan
2017-04-19  9:57     ` Amir Goldstein
2017-04-19 10:02       ` Eryu Guan
2017-04-18 18:17 ` [PATCH 3/4] fstests: add helper _require_exportfs Amir Goldstein
2017-04-19  9:44   ` Eryu Guan
2017-04-19  9:50   ` David Howells
2017-04-18 18:17 ` [PATCH 4/4] fstests: add generic test for file handles Amir Goldstein
2017-04-19  9:55   ` Eryu Guan
2017-04-19 10:07     ` Amir Goldstein
2017-04-19 10:41       ` Eryu Guan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170419104142.GW8951@eguan.usersys.redhat.com \
    --to=eguan@redhat.com \
    --cc=amir73il@gmail.com \
    --cc=bfields@fieldses.org \
    --cc=fstests@vger.kernel.org \
    --cc=jlayton@poochiereds.net \
    --cc=linux-unionfs@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    --cc=trondmy@primarydata.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.