From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com ([66.111.4.25]:43913 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964920AbdDSO6d (ORCPT ); Wed, 19 Apr 2017 10:58:33 -0400 Date: Wed, 19 Apr 2017 16:57:10 +0200 From: Greg KH To: Kees Cook Cc: Arjan van de Ven , Ben Hutchings , stable , Thomas Gleixner , John Stultz Subject: Re: [stable] Removing or restricting timer_stats Message-ID: <20170419145709.GA19812@kroah.com> References: <1492482305.2409.135.camel@decadent.org.uk> <20170419115018.GH27378@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: stable-owner@vger.kernel.org List-ID: On Wed, Apr 19, 2017 at 07:54:34AM -0700, Kees Cook wrote: > On Wed, Apr 19, 2017 at 4:50 AM, Greg KH wrote: > > On Tue, Apr 18, 2017 at 03:25:05AM +0100, Ben Hutchings wrote: > >> The timer_stats feature was removed upstream by: > >> > >> commit dfb4357da6ddbdf57d583ba64361c9d792b0e0b1 > >> Author: Kees Cook > >> Date: Wed Feb 8 11:26:59 2017 -0800 > >> > >> time: Remove CONFIG_TIMER_STATS > >> > >> I'm hesitant to propose removing a feature in stable, even if it is > >> redundant. What I've done for Debian stable is to restrict it to the > >> initial pid namespace (see attached). Would that be a reasonable > >> alternative change for stable branches? > > > > I don't mind removing things in stable as that's what happened in > > Linus's tree, and it was removed for a reason. We've done it before, > > and I'm more hesitant to apply something that works a bit > > "differently". > > > > Kees, any objection for me just taking the "full" patch in the stable > > kernels? > > Arjan said it would break powertop, IIRC. So we broke it in 4.11? That doesn't seem to sound reasonable, how are you getting away with that? :) thanks, greg k-h