From: Darren Hart <dvhart@infradead.org>
To: Carlo Caione <carlo@caione.org>
Cc: andy@infradead.org, andy.shevchenko@gmail.com,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org, linux@endlessm.com,
Carlo Caione <carlo@endlessm.com>
Subject: Re: [PATCH] hp-wmi: Do not shadow error values
Date: Wed, 19 Apr 2017 13:56:44 -0700 [thread overview]
Message-ID: <20170419205644.GD17351@fury> (raw)
In-Reply-To: <20170419203639.28788-1-carlo@caione.org>
On Wed, Apr 19, 2017 at 10:36:39PM +0200, Carlo Caione wrote:
> From: Carlo Caione <carlo@endlessm.com>
>
> All the helper functions (i.e. hp_wmi_dock_state, hp_wmi_tablet_state,
> ...) using hp_wmi_perform_query to perform an HP WMI query shadow the
> returned value in case of error.
>
> We return -EINVAL only when the HP WMI query returns a positive value
> (the specific error code) to not mix this up with the actual value
> returned by the helper function.
>
> Signed-off-by: Carlo Caione <carlo@endlessm.com>
Queued to testing, thanks Carlo.
--
Darren Hart
VMware Open Source Technology Center
prev parent reply other threads:[~2017-04-19 20:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-19 20:36 [PATCH] hp-wmi: Do not shadow error values Carlo Caione
2017-04-19 20:56 ` Darren Hart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170419205644.GD17351@fury \
--to=dvhart@infradead.org \
--cc=andy.shevchenko@gmail.com \
--cc=andy@infradead.org \
--cc=carlo@caione.org \
--cc=carlo@endlessm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@endlessm.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.