From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Andi Kleen <andi@firstfloor.org>
Cc: jolsa@kernel.org, linux-kernel@vger.kernel.org,
Andi Kleen <ak@linux.intel.com>,
eranian@google.com
Subject: Re: [PATCH] perf, tools: Fix display of data source snoop indication
Date: Wed, 19 Apr 2017 18:53:33 -0300 [thread overview]
Message-ID: <20170419215332.GB3929@kernel.org> (raw)
In-Reply-To: <20170419195337.14575-1-andi@firstfloor.org>
Em Wed, Apr 19, 2017 at 12:53:37PM -0700, Andi Kleen escreveu:
> From: Andi Kleen <ak@linux.intel.com>
>
> perf mem report doesn't display the data source snoop indication correctly.
>
> In the kernel API the definition is
I fixed this already, prepending the lines starting with # with two
spaces, so that it doesn't vanishes one 3rd time 8-)
- Arnaldo
> but the table used by the perf tools exchanged Hit and Miss
>
> "None",
> "Miss",
> "Hit",
>
> Fix the table in perf.
>
> Cc: eranian@google.com
> Signed-off-by: Andi Kleen <ak@linux.intel.com>
> ---
> tools/perf/util/mem-events.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/mem-events.c b/tools/perf/util/mem-events.c
> index 1d4ab53c60ca..865ba3c39284 100644
> --- a/tools/perf/util/mem-events.c
> +++ b/tools/perf/util/mem-events.c
> @@ -205,8 +205,8 @@ int perf_mem__lvl_scnprintf(char *out, size_t sz, struct mem_info *mem_info)
> static const char * const snoop_access[] = {
> "N/A",
> "None",
> - "Miss",
> "Hit",
> + "Miss",
> "HitM",
> };
>
> --
> 2.9.3
next prev parent reply other threads:[~2017-04-19 21:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-19 19:53 [PATCH] perf, tools: Fix display of data source snoop indication Andi Kleen
2017-04-19 21:53 ` Arnaldo Carvalho de Melo [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-04-19 17:49 Andi Kleen
2017-04-19 18:46 ` Arnaldo Carvalho de Melo
2017-04-19 18:50 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170419215332.GB3929@kernel.org \
--to=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=eranian@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.