From: Dave Chinner <david@fromorbit.com>
To: Jan Tulak <jtulak@redhat.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/2] mkfs: unify numeric types of main variables in main()
Date: Thu, 20 Apr 2017 10:09:09 +1000 [thread overview]
Message-ID: <20170420000909.GI12369@dastard> (raw)
In-Reply-To: <20170419153025.10368-1-jtulak@redhat.com>
On Wed, Apr 19, 2017 at 05:30:24PM +0200, Jan Tulak wrote:
> Followup of my "[xfsprogs] Do we need so many data types for user input?" email.
> This version has bool for flags and uses PRIu64 for printing 64bit values.
>
> Other issues from RFC, that I didn't get a satisfactory feedback to:
> * __uint64_t is used because it is declared in xfsprogs, so unless there is a
> reason to not use it (e.g. the declared type is just for some special use,
> or is obsolete), I'm sticking to it.
uint64_t is a standard C99 type. Please use it over an internal
type that we plan to get rid of. i.e.
http://oss.sgi.com/archives/xfs/2016-01/msg00386.html
These patches were never finalised/finished because of conflicts
with all the COW work that was pending at the time. This type
conversion still needs to be picked up and finished...
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2017-04-20 0:09 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-19 15:30 [PATCH 1/2] mkfs: unify numeric types of main variables in main() Jan Tulak
2017-04-19 15:30 ` [PATCH 2/2] mkfs: remove long long type casts Jan Tulak
2017-04-20 8:33 ` [PATCH 2/2 v2] " Jan Tulak
2017-04-25 1:40 ` [PATCH 2/2] " Luis R. Rodriguez
2017-04-20 0:09 ` Dave Chinner [this message]
2017-04-20 8:06 ` [PATCH 1/2] mkfs: unify numeric types of main variables in main() Jan Tulak
2017-04-20 8:33 ` [PATCH 1/2 v2] " Jan Tulak
2017-04-20 13:28 ` Luis R. Rodriguez
2017-04-20 13:57 ` Jan Tulak
2017-04-26 3:58 ` Eric Sandeen
2017-04-26 7:58 ` Jan Tulak
2017-05-09 15:49 ` Eric Sandeen
2017-04-20 13:58 ` [PATCH 1/2 v3] " Jan Tulak
2017-04-25 1:37 ` Luis R. Rodriguez
2017-04-25 12:07 ` Jan Tulak
2017-04-26 1:57 ` Luis R. Rodriguez
2017-04-26 8:03 ` Jan Tulak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170420000909.GI12369@dastard \
--to=david@fromorbit.com \
--cc=jtulak@redhat.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.