Re: [Qemu-devel] [PATCH v2] iotests: 109: Filter out "len" of failed jobs

[Fam Zheng <famz@redhat.com>]

On Wed, 04/19 19:13, Kevin Wolf wrote:
> Am 19.04.2017 um 11:17 hat Fam Zheng geschrieben:
> > Mirror calculates job len from current I/O progress:
> > 
> >     s->common.len = s->common.offset +
> >                     (cnt + s->sectors_in_flight) * BDRV_SECTOR_SIZE;
> > 
> > The final "len" of a failed mirror job in iotests 109 depends on the
> > subtle timing of the completion of read and write issued in the first
> > mirror iteration.  The second iteration may or may not have run when the
> > I/O error happens, resulting in non-deterministic output of the
> > BLOCK_JOB_COMPLETED event text.
> > 
> > Similar to what was done in a752e4786, filter out the field to make the
> > test robust.
> > 
> > Tested-by: Eric Blake <eblake@redhat.com>
> > Reviewed-by: Eric Blake <eblake@redhat.com>
> > Signed-off-by: Fam Zheng <famz@redhat.com>
> 
> This improves things a bit, but the test case is still failing for me.
> It's not deterministic, so the following is just an example.

OK, I'll revise the patch and send v3.

Fam