From: Jiri Olsa <jolsa@redhat.com>
To: Taeung Song <treeze.taeung@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
David Ahern <dsahern@gmail.com>,
Namhyung Kim <namhyung@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Jin Yao <yao.jin@linux.intel.com>,
lkml <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH perf/urgent] perf tools: Fix the code to strip command name
Date: Thu, 20 Apr 2017 12:35:43 +0200 [thread overview]
Message-ID: <20170420103543.GA1681@krava> (raw)
In-Reply-To: <eb206d12-ab32-dfc6-5c7a-76a7daa01374@gmail.com>
On Thu, Apr 20, 2017 at 07:17:34PM +0900, Taeung Song wrote:
> Hi Jiri,
>
> On 04/20/2017 06:24 PM, Jiri Olsa wrote:
> > Recent commit broke command name strip in perf_event__get_comm_ids
> > function. It replaced left to right search for '\n' with rtrim,
> > which actually does right to left search. It occasionally caught
> > earlier '\n' and kept trash in the command name.
>
> Sorry for my commit that have failings.
>
> Could I know the command name in the above case ?
> The command name can have two '\n' ?
it's the next line in the status file.. parts of the Umask string
and 1 newline
Name: systemd
Umask: 0000
State: S (sleeping)
...
I've already posted it in here:
http://marc.info/?l=linuxppc-embedded&m=149200723316270&w=2
jirka
next prev parent reply other threads:[~2017-04-20 10:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-20 9:24 [PATCH perf/urgent] perf tools: Fix the code to strip command name Jiri Olsa
2017-04-20 10:17 ` Taeung Song
2017-04-20 10:35 ` Jiri Olsa [this message]
2017-04-20 10:42 ` Taeung Song
2017-04-20 10:49 ` Jiri Olsa
2017-04-24 11:37 ` Jiri Olsa
2017-04-24 15:44 ` Arnaldo Carvalho de Melo
2017-04-24 16:06 ` Jiri Olsa
2017-04-24 16:28 ` Arnaldo Carvalho de Melo
2017-04-24 21:17 ` [tip:perf/core] " tip-bot for Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170420103543.GA1681@krava \
--to=jolsa@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=dsahern@gmail.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=treeze.taeung@gmail.com \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.