From mboxrd@z Thu Jan 1 00:00:00 1970 From: chrubis@suse.cz (Cyril Hrubis) Date: Thu, 20 Apr 2017 14:57:50 +0200 Subject: [LTP] [lkp-robot] [KEYS] bdf7c0f8bf: ltp.add_key02.fail In-Reply-To: <20170417172955.GA31469@gmail.com> References: <20170401213428.17097-1-ebiggers3@gmail.com> <20170417062641.GN31394@yexl-desktop> <20170417172955.GA31469@gmail.com> Message-ID: <20170420125750.GD10246@rei.lan> To: linux-security-module@vger.kernel.org List-Id: linux-security-module.vger.kernel.org Hi! > > commit: bdf7c0f8bf282ba44827ce3c7fd7936c8e90a18a ("KEYS: fix dereferencing NULL payload with nonzero length") > > url: https://github.com/0day-ci/linux/commits/Eric-Biggers/KEYS-fix-dereferencing-NULL-payload-with-nonzero-length/20170403-102013 > > base: https://git.kernel.org/cgit/linux/kernel/git/jmorris/linux-security.git next > > > ... > > caused below changes (please refer to attached dmesg/kmsg for entire log/backtrace): > > > > > > user :notice: [ 45.447047] <<>> > > > > user :notice: [ 45.447365] tag=add_key02 stime=1492169102 > > > > user :notice: [ 45.447567] cmdline="add_key02" > > > > user :notice: [ 45.447685] contacts="" > > > > user :notice: [ 45.447826] analysis=exit > > > > user :notice: [ 45.448011] <<>> > > > > user :notice: [ 45.448568] tst_test.c:760: INFO: Timeout per run is 0h 05m 00s > > > > user :notice: [ 45.449439] add_key02.c:65: FAIL: add_key() failed unexpectedly, expected EINVAL: EFAULT > > In my opinion this is a valid behavior, and the test is just weird; it's passing > in *both* an unaddressable payload and an invalid description, so it's not clear > which case it's meant to be testing. (Generally, if a syscall will fail for > more than one reason, it's not guaranteed which error code you'll get.) That is quite common problem with LTP testcases. Do you care to send a patch or should I fix that? > In any case, once we have a fix merged, it would be nice for there to be an ltp > test added for the "NULL payload with nonzero length" case with one of the key > types that crashed the kernel. Here as well, feel free to send a patch or at least point us to a reproducer that could be turned into a testcase. -- Cyril Hrubis chrubis at suse.cz -- To unsubscribe from this list: send the line "unsubscribe linux-security-module" in the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cyril Hrubis Date: Thu, 20 Apr 2017 14:57:50 +0200 Subject: [LTP] [lkp-robot] [KEYS] bdf7c0f8bf: ltp.add_key02.fail In-Reply-To: <20170417172955.GA31469@gmail.com> References: <20170401213428.17097-1-ebiggers3@gmail.com> <20170417062641.GN31394@yexl-desktop> <20170417172955.GA31469@gmail.com> Message-ID: <20170420125750.GD10246@rei.lan> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ltp@lists.linux.it Hi! > > commit: bdf7c0f8bf282ba44827ce3c7fd7936c8e90a18a ("KEYS: fix dereferencing NULL payload with nonzero length") > > url: https://github.com/0day-ci/linux/commits/Eric-Biggers/KEYS-fix-dereferencing-NULL-payload-with-nonzero-length/20170403-102013 > > base: https://git.kernel.org/cgit/linux/kernel/git/jmorris/linux-security.git next > > > ... > > caused below changes (please refer to attached dmesg/kmsg for entire log/backtrace): > > > > > > user :notice: [ 45.447047] <<>> > > > > user :notice: [ 45.447365] tag=add_key02 stime=1492169102 > > > > user :notice: [ 45.447567] cmdline="add_key02" > > > > user :notice: [ 45.447685] contacts="" > > > > user :notice: [ 45.447826] analysis=exit > > > > user :notice: [ 45.448011] <<>> > > > > user :notice: [ 45.448568] tst_test.c:760: INFO: Timeout per run is 0h 05m 00s > > > > user :notice: [ 45.449439] add_key02.c:65: FAIL: add_key() failed unexpectedly, expected EINVAL: EFAULT > > In my opinion this is a valid behavior, and the test is just weird; it's passing > in *both* an unaddressable payload and an invalid description, so it's not clear > which case it's meant to be testing. (Generally, if a syscall will fail for > more than one reason, it's not guaranteed which error code you'll get.) That is quite common problem with LTP testcases. Do you care to send a patch or should I fix that? > In any case, once we have a fix merged, it would be nice for there to be an ltp > test added for the "NULL payload with nonzero length" case with one of the key > types that crashed the kernel. Here as well, feel free to send a patch or at least point us to a reproducer that could be turned into a testcase. -- Cyril Hrubis chrubis@suse.cz From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============5578349552269903363==" MIME-Version: 1.0 From: Cyril Hrubis To: lkp@lists.01.org Subject: Re: [LTP] [lkp-robot] [KEYS] bdf7c0f8bf: ltp.add_key02.fail Date: Thu, 20 Apr 2017 14:57:50 +0200 Message-ID: <20170420125750.GD10246@rei.lan> In-Reply-To: <20170417172955.GA31469@gmail.com> List-Id: --===============5578349552269903363== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi! > > commit: bdf7c0f8bf282ba44827ce3c7fd7936c8e90a18a ("KEYS: fix dereferenc= ing NULL payload with nonzero length") > > url: https://github.com/0day-ci/linux/commits/Eric-Biggers/KEYS-fix-der= eferencing-NULL-payload-with-nonzero-length/20170403-102013 > > base: https://git.kernel.org/cgit/linux/kernel/git/jmorris/linux-securi= ty.git next > > = > ... > > caused below changes (please refer to attached dmesg/kmsg for entire lo= g/backtrace): > > = > > = > > user :notice: [ 45.447047] <<>> > > = > > user :notice: [ 45.447365] tag=3Dadd_key02 stime=3D1492169102 > > = > > user :notice: [ 45.447567] cmdline=3D"add_key02" > > = > > user :notice: [ 45.447685] contacts=3D"" > > = > > user :notice: [ 45.447826] analysis=3Dexit > > = > > user :notice: [ 45.448011] <<>> > > = > > user :notice: [ 45.448568] tst_test.c:760: INFO: Timeout per run is = 0h 05m 00s > > = > > user :notice: [ 45.449439] add_key02.c:65: FAIL: add_key() failed un= expectedly, expected EINVAL: EFAULT > = > In my opinion this is a valid behavior, and the test is just weird; it's = passing > in *both* an unaddressable payload and an invalid description, so it's no= t clear > which case it's meant to be testing. (Generally, if a syscall will fail = for > more than one reason, it's not guaranteed which error code you'll get.) That is quite common problem with LTP testcases. Do you care to send a patch or should I fix that? > In any case, once we have a fix merged, it would be nice for there to be = an ltp > test added for the "NULL payload with nonzero length" case with one of th= e key > types that crashed the kernel. Here as well, feel free to send a patch or at least point us to a reproducer that could be turned into a testcase. -- = Cyril Hrubis chrubis(a)suse.cz --===============5578349552269903363==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S945540AbdDTM6T (ORCPT ); Thu, 20 Apr 2017 08:58:19 -0400 Received: from mx2.suse.de ([195.135.220.15]:40807 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S945521AbdDTM6O (ORCPT ); Thu, 20 Apr 2017 08:58:14 -0400 Date: Thu, 20 Apr 2017 14:57:50 +0200 From: Cyril Hrubis To: Eric Biggers Cc: kernel test robot , Eric Biggers , linux-kernel@vger.kernel.org, stable@vger.kernel.org, David Howells , linux-security-module@vger.kernel.org, keyrings@vger.kernel.org, lkp@01.org, ltp@lists.linux.it Subject: Re: [LTP] [lkp-robot] [KEYS] bdf7c0f8bf: ltp.add_key02.fail Message-ID: <20170420125750.GD10246@rei.lan> References: <20170401213428.17097-1-ebiggers3@gmail.com> <20170417062641.GN31394@yexl-desktop> <20170417172955.GA31469@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170417172955.GA31469@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi! > > commit: bdf7c0f8bf282ba44827ce3c7fd7936c8e90a18a ("KEYS: fix dereferencing NULL payload with nonzero length") > > url: https://github.com/0day-ci/linux/commits/Eric-Biggers/KEYS-fix-dereferencing-NULL-payload-with-nonzero-length/20170403-102013 > > base: https://git.kernel.org/cgit/linux/kernel/git/jmorris/linux-security.git next > > > ... > > caused below changes (please refer to attached dmesg/kmsg for entire log/backtrace): > > > > > > user :notice: [ 45.447047] <<>> > > > > user :notice: [ 45.447365] tag=add_key02 stime=1492169102 > > > > user :notice: [ 45.447567] cmdline="add_key02" > > > > user :notice: [ 45.447685] contacts="" > > > > user :notice: [ 45.447826] analysis=exit > > > > user :notice: [ 45.448011] <<>> > > > > user :notice: [ 45.448568] tst_test.c:760: INFO: Timeout per run is 0h 05m 00s > > > > user :notice: [ 45.449439] add_key02.c:65: FAIL: add_key() failed unexpectedly, expected EINVAL: EFAULT > > In my opinion this is a valid behavior, and the test is just weird; it's passing > in *both* an unaddressable payload and an invalid description, so it's not clear > which case it's meant to be testing. (Generally, if a syscall will fail for > more than one reason, it's not guaranteed which error code you'll get.) That is quite common problem with LTP testcases. Do you care to send a patch or should I fix that? > In any case, once we have a fix merged, it would be nice for there to be an ltp > test added for the "NULL payload with nonzero length" case with one of the key > types that crashed the kernel. Here as well, feel free to send a patch or at least point us to a reproducer that could be turned into a testcase. -- Cyril Hrubis chrubis@suse.cz