From: "Daniel P. Berrange" <berrange@redhat.com>
To: Fam Zheng <famz@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
lvivier@redhat.com, qemu-block@nongnu.org, quintela@redhat.com,
qemu-devel@nongnu.org, dgilbert@redhat.com, mreitz@redhat.com,
stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 3/3] qemu-iotests: Test postcopy migration
Date: Thu, 20 Apr 2017 15:39:17 +0100 [thread overview]
Message-ID: <20170420143917.GG3227@redhat.com> (raw)
In-Reply-To: <20170420141827.GN24486@lemon.lan>
On Thu, Apr 20, 2017 at 10:18:27PM +0800, Fam Zheng wrote:
> On Wed, 04/19 17:16, Kevin Wolf wrote:
> > +_supported_fmt generic
>
> This doesn't work for formats that install migration blockers, so maybe
> s/generic/raw qcow2/ instead?
It would be nice to use a more feature driven check and centralize
knowledge of which formats are migratable. eg define a
"_migratable_fmt" function in common.rc that checks a MIGRATABLE_FMT
env variable, and in 'common' where we process the command line args,
set MIGRATABLE_FMT for each format or protocol as needed.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2017-04-20 14:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-19 15:15 [Qemu-devel] [PATCH v2 0/3] migration: Call blk_resume_after_migration() for postcopy Kevin Wolf
2017-04-19 15:16 ` [Qemu-devel] [PATCH v2 1/3] " Kevin Wolf
2017-04-19 15:16 ` [Qemu-devel] [PATCH v2 2/3] qemu-iotests: Filter HMP readline escape characters Kevin Wolf
2017-04-19 15:31 ` Eric Blake
2017-04-19 15:16 ` [Qemu-devel] [PATCH v2 3/3] qemu-iotests: Test postcopy migration Kevin Wolf
2017-04-20 14:18 ` Fam Zheng
2017-04-20 14:39 ` Daniel P. Berrange [this message]
2017-05-03 13:33 ` [Qemu-devel] [PATCH v2 0/3] migration: Call blk_resume_after_migration() for postcopy Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170420143917.GG3227@redhat.com \
--to=berrange@redhat.com \
--cc=dgilbert@redhat.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=lvivier@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.