From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S970732AbdDTPfi (ORCPT ); Thu, 20 Apr 2017 11:35:38 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:52019 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S970369AbdDTPfe (ORCPT ); Thu, 20 Apr 2017 11:35:34 -0400 Date: Thu, 20 Apr 2017 08:35:29 -0700 From: "Paul E. McKenney" To: Arnd Bergmann Cc: Josh Triplett , Steven Rostedt , Mathieu Desnoyers , Lai Jiangshan , SeongJae Park , Ingo Molnar , linux-kernel@vger.kernel.org Subject: Re: [PATCH] rcuperf: refix rcuperf sched_ops definition Reply-To: paulmck@linux.vnet.ibm.com References: <20170420081247.657073-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170420081247.657073-1-arnd@arndb.de> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-GCONF: 00 x-cbid: 17042015-0052-0000-0000-000001DF520A X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00006945; HX=3.00000240; KW=3.00000007; PH=3.00000004; SC=3.00000208; SDB=6.00850135; UDB=6.00419855; IPR=6.00628764; BA=6.00005305; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00015110; XFM=3.00000013; UTC=2017-04-20 15:35:32 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17042015-0053-0000-0000-00005019CA41 Message-Id: <20170420153529.GP3956@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-04-20_14:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1703280000 definitions=main-1704200125 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 20, 2017 at 10:12:31AM +0200, Arnd Bergmann wrote: > It looks like my fixup was incorrectly folded into the original patch, > and still leaves a duplicated initializer but drops the .sync > callback pointer. > > This should rectify it, please fold it as well. > > Fixes: df29028c2a9c ("rcuperf: Add ability to performance-test call_rcu() and friends") > Signed-off-by: Arnd Bergmann I really am not doing well on this commit, am I? :-/ Thank you very much for your attention to detail and for the fixes!!! Thanx, Paul > --- > kernel/rcu/rcuperf.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/rcu/rcuperf.c b/kernel/rcu/rcuperf.c > index 1e2a1424d1f5..5158ddba6716 100644 > --- a/kernel/rcu/rcuperf.c > +++ b/kernel/rcu/rcuperf.c > @@ -308,7 +308,7 @@ static struct rcu_perf_ops sched_ops = { > .exp_completed = rcu_exp_batches_completed_sched, > .async = call_rcu_sched, > .gp_barrier = rcu_barrier_sched, > - .async = srcu_call_rcu, > + .sync = synchronize_sched, > .exp_sync = synchronize_sched_expedited, > .name = "sched" > }; > -- > 2.9.0 >