From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm: fourcc byteorder: brings header file comments in line with reality. Date: Fri, 21 Apr 2017 12:44:49 +0300 Message-ID: <20170421094449.GF30290@intel.com> References: <20170421075825.6307-1-kraxel@redhat.com> <20170421110605.1a255f44@eldfell> <1492767508.25675.23.camel@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <1492767508.25675.23.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Gerd Hoffmann Cc: Jani Nikula , David Airlie , Michel =?iso-8859-1?Q?D=E4nzer?= , open list , dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Pekka Paalanen , Sean Paul , amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Alex Deucher , Daniel Vetter , Ilia Mirkin T24gRnJpLCBBcHIgMjEsIDIwMTcgYXQgMTE6Mzg6MjhBTSArMDIwMCwgR2VyZCBIb2ZmbWFubiB3 cm90ZToKPiAgIEhpLAo+IAo+ID4gPiBMZWF2aW5nIHRoZSB5dXYgZm9ybWF0cyBhcy1pcy4gIEkg aGF2ZSBubyBpZGVhIGlmIGFuZCBob3cgdGhvc2UgYXJlIHVzZWQKPiA+ID4gb24gYmlnZW5kaWFu IG1hY2hpbmVzLgo+IAo+ID4ganVzdCBhbiBpZGVhIC0gc2luY2Ugd2UgYXJlIG5vdCBzdXJlIGhv dyB0aGUgcmVtYWluaW5nIGZvcm1hdHMgYXJlIGJlaW5nCj4gPiB1c2VkLCBzaG91bGQgdGhvc2Ug YmUgbWFya2VkIHNvbWVob3cgdW5jZXJ0YWluIHdoZXRoZXIgdGhleSBhcmUgbGl0dGxlCj4gPiBv ciBuYXRpdmUgZW5kaWFuPwo+IAo+IEFUTSB0aGUgeXV2IGRvbid0IGhhdmUgYW55IGJ5dGUgb3Jk ZXIgYW5ub3RhdGlvbnMsIGFuZCBJIHNpbXBseSBsZWZ0Cj4gdGhlbSB0aGF0IHdheS4gIFNvIGl0 IGlzIGFzIGNsZWFyL3VuY2xlYXIgYXMgYmVmb3JlLgoKRWg/IEV2ZXJ5dGhpbmcgdGhhdCBpcyBh ZmZlY3RlZCBieSBieXRlIG9yZGVyIGhhcyB0aGUgcmVsZXZhbnQgY29tbWVudHMuCklmIHRoZXkg ZG9uJ3QsIHRoZW4gdGhhdCdzIGEgYnVnLgoKPiAKPiBJSVJDIHNvbWVvbmUgbWVudGlvbmVkIHRo YXQgZm9yIHRoZSB5dXYgZm91cmNjcyB0aGVyZSBhY3R1YWxseSBpcyBzb21lCj4gc3RhbmRhcmQg YWJvdXQgdGhlIGV4YWN0IG9yZGVyaW5nLiAgQW55b25lIGhhcyBhIGdvb2QgcmVmZXJlbmNlPyAg V2UKPiBjb3VsZCBzdGljayBhIGxpbmsgdG8gaXQgaW50byBhIGNvbW1lbnQuCgpUaGUgInN0YW5k YXJkIiBpcyBmb3VyY2MuIFdoZXRoZXIgdGhlcmUgaXMgYW55IG9mZmljaWFsIHJlZmVyZW5jZSBm b3IKdGhhdCBpcyB1bmNsZWFyLiBUaGF0J3MgZXhhY3RseSB3aHkgSSBhZGRlZCB0aGUgZXhwbGlj aXQgY29tbWVudHMgaW50bwpkcm1fZm91cmNjLmggc28gdGhhdCBwZW9wbGUgZG9uJ3QgaGF2ZSB0 byBnbyB0cmF3bGluZyB0aGUgaW50ZXJuZXRzCmxvb2tpbmcgZm9yIGluZm9ybWF0aW9uIG9uIHdo YXQgZWFjaCBwaXhlbCBmb3JtYXQgbWlnaHQgbWVhbi4KCi0tIApWaWxsZSBTeXJqw6Rsw6QKSW50 ZWwgT1RDCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmFt ZC1nZnggbWFpbGluZyBsaXN0CmFtZC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8v bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vYW1kLWdmeAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1037479AbdDUJpA (ORCPT ); Fri, 21 Apr 2017 05:45:00 -0400 Received: from mga05.intel.com ([192.55.52.43]:42941 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1037439AbdDUJo4 (ORCPT ); Fri, 21 Apr 2017 05:44:56 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,229,1488873600"; d="scan'208";a="1138504949" Date: Fri, 21 Apr 2017 12:44:49 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Gerd Hoffmann Cc: Pekka Paalanen , dri-devel@lists.freedesktop.org, Daniel Vetter , Ilia Mirkin , Michel =?iso-8859-1?Q?D=E4nzer?= , Alex Deucher , amd-gfx@lists.freedesktop.org, Jani Nikula , Sean Paul , David Airlie , open list Subject: Re: [PATCH] drm: fourcc byteorder: brings header file comments in line with reality. Message-ID: <20170421094449.GF30290@intel.com> References: <20170421075825.6307-1-kraxel@redhat.com> <20170421110605.1a255f44@eldfell> <1492767508.25675.23.camel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1492767508.25675.23.camel@redhat.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 21, 2017 at 11:38:28AM +0200, Gerd Hoffmann wrote: > Hi, > > > > Leaving the yuv formats as-is. I have no idea if and how those are used > > > on bigendian machines. > > > just an idea - since we are not sure how the remaining formats are being > > used, should those be marked somehow uncertain whether they are little > > or native endian? > > ATM the yuv don't have any byte order annotations, and I simply left > them that way. So it is as clear/unclear as before. Eh? Everything that is affected by byte order has the relevant comments. If they don't, then that's a bug. > > IIRC someone mentioned that for the yuv fourccs there actually is some > standard about the exact ordering. Anyone has a good reference? We > could stick a link to it into a comment. The "standard" is fourcc. Whether there is any official reference for that is unclear. That's exactly why I added the explicit comments into drm_fourcc.h so that people don't have to go trawling the internets looking for information on what each pixel format might mean. -- Ville Syrjälä Intel OTC