From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/i915: Avoid busy-spinning on VLV_GLTC_PW_STATUS mmio Date: Fri, 21 Apr 2017 16:38:49 +0300 Message-ID: <20170421133849.GM30290@intel.com> References: <20170421130040.5450-1-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 654A06E507 for ; Fri, 21 Apr 2017 13:38:53 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20170421130040.5450-1-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson Cc: Tomi Sarvela , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBBcHIgMjEsIDIwMTcgYXQgMDI6MDA6NDBQTSArMDEwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IFRoZSBidXN5LXNwaW4sIGFzIHRoZSBmaXJzdCBzdGFnZSBvZiBpbnRlbF93YWl0X2Zv cl9yZWdpc3RlciwgaXMKPiBjdXJyZW50bHkgdW5kZXIgc3VzcGljaW9uIGZvciBjYXVzaW5nOgo+ IAo+IFsgICA2Mi4wMzQ5MjZdIE5NSSB3YXRjaGRvZzogV2F0Y2hkb2cgZGV0ZWN0ZWQgaGFyZCBM T0NLVVAgb24gY3B1IDEKPiBbICAgNjIuMDM0OTI4XSBNb2R1bGVzIGxpbmtlZCBpbjogaTJjX2Rl diBpOTE1IGludGVsX2d0dCBkcm1fa21zX2hlbHBlciBwcmltZV9udW1iZXJzCj4gWyAgIDYyLjAz NDkzMl0gQ1BVOiAxIFBJRDogMTgzIENvbW06IGt3b3JrZXIvMToyIE5vdCB0YWludGVkIDQuMTEu MC1yYzcrICM0NzEKPiBbICAgNjIuMDM0OTMzXSBIYXJkd2FyZSBuYW1lOiAgICAgICAgICAgICAg ICAgIC8gICAgICAgICwgQklPUyBQWUJTV0NFTC44NkEuMDAyNy4yMDE1LjA1MDcuMTc1OCAwNS8w Ny8yMDE1Cj4gWyAgIDYyLjAzNDkzNF0gV29ya3F1ZXVlOiBwbSBwbV9ydW50aW1lX3dvcmsKPiBb ICAgNjIuMDM0OTM2XSB0YXNrOiBmZmZmODgwMjc1YTA0ZWMwIHRhc2suc3RhY2s6IGZmZmZjOTAw MDAyZDgwMDAKPiBbICAgNjIuMDM0OTM2XSBSSVA6IDAwMTA6X19pbnRlbF93YWl0X2Zvcl9yZWdp c3Rlcl9mdysweDc3LzB4MWEwIFtpOTE1XQo+IFsgICA2Mi4wMzQ5MzddIFJTUDogMDAxODpmZmZm YzkwMDAwMmRiYzM4IEVGTEFHUzogMDAwMDAwODIKPiBbICAgNjIuMDM0OTM5XSBSQVg6IGZmZmZj OTAwMDM1MzAwOTQgUkJYOiAwMDAwMDAwMDAwMTMwMDk0IFJDWDogMDAwMDAwMDAwMDAwMDAwMQo+ IFsgICA2Mi4wMzQ5NDBdIFJEWDogMDAwMDAwMDAwMDAwMDBhMSBSU0k6IGZmZmY4ODAyN2ZkMTVl NTggUkRJOiAwMDAwMDAwMDAwMDAwMDAwCj4gWyAgIDYyLjAzNDk0MV0gUkJQOiBmZmZmYzkwMDAw MmRiYzc4IFIwODogMDAwMDAwMDAwMDAwMDAwMiBSMDk6IDAwMDAwMDAwMDAwMDAwMDAKPiBbICAg NjIuMDM0OTQyXSBSMTA6IGZmZmZjOTAwMDAyZGJjMTggUjExOiBmZmZmODgwMjc2NDI5ZGQwIFIx MjogZmZmZjg4MDI3MDdjMDAwMAo+IFsgICA2Mi4wMzQ5NDNdIFIxMzogMDAwMDAwMDAwMDAwMDBh MCBSMTQ6IDAwMDAwMDAwMDAwMDAwMDAgUjE1OiAwMDAwMDAwMGZmZmVmYzEwCj4gWyAgIDYyLjAz NDk0NV0gRlM6ICAwMDAwMDAwMDAwMDAwMDAwKDAwMDApIEdTOmZmZmY4ODAyN2ZkMDAwMDAoMDAw MCkga25sR1M6MDAwMDAwMDAwMDAwMDAwMAo+IFsgICA2Mi4wMzQ5NDVdIENTOiAgMDAxMCBEUzog MDAwMCBFUzogMDAwMCBDUjA6IDAwMDAwMDAwODAwNTAwMzMKPiBbICAgNjIuMDM0OTQ3XSBDUjI6 IDAwMDA3ZmZkM2NkOThmZjggQ1IzOiAwMDAwMDAwMjc0YzE5MDAwIENSNDogMDAwMDAwMDAwMDEw MDZlMAo+IFsgICA2Mi4wMzQ5NDddIENhbGwgVHJhY2U6Cj4gWyAgIDYyLjAzNDk0OF0gIGludGVs X3dhaXRfZm9yX3JlZ2lzdGVyKzB4NzcvMHgxNDAgW2k5MTVdCj4gWyAgIDYyLjAzNDk0OV0gIHZs dl9zdXNwZW5kX2NvbXBsZXRlKzB4MjMvMHg1YjAgW2k5MTVdCj4gWyAgIDYyLjAzNDk1MF0gIGlu dGVsX3J1bnRpbWVfc3VzcGVuZCsweDE2Yy8weDJhMCBbaTkxNV0KPiBbICAgNjIuMDM0OTUwXSAg cGNpX3BtX3J1bnRpbWVfc3VzcGVuZCsweDUwLzB4MTgwCj4gWyAgIDYyLjAzNDk1MV0gID8gcGNp X3BtX3J1bnRpbWVfcmVzdW1lKzB4YTAvMHhhMAo+IFsgICA2Mi4wMzQ5NTJdICBfX3JwbV9jYWxs YmFjaysweGM1LzB4MjEwCj4gWyAgIDYyLjAzNDk1M10gIHJwbV9jYWxsYmFjaysweDFmLzB4ODAK PiBbICAgNjIuMDM0OTUzXSAgPyBwY2lfcG1fcnVudGltZV9yZXN1bWUrMHhhMC8weGEwCj4gWyAg IDYyLjAzNDk1NF0gIHJwbV9zdXNwZW5kKzB4MTE4LzB4NTgwCj4gWyAgIDYyLjAzNDk1NV0gIHBt X3J1bnRpbWVfd29yaysweDY0LzB4OTAKPiBbICAgNjIuMDM0OTU2XSAgcHJvY2Vzc19vbmVfd29y aysweDFiYi8weDNlMAo+IFsgICA2Mi4wMzQ5NTZdICB3b3JrZXJfdGhyZWFkKzB4NDYvMHg0ZjAK PiBbICAgNjIuMDM0OTU3XSAgPyBfX3NjaGVkdWxlKzB4MThiLzB4NjEwCj4gWyAgIDYyLjAzNDk1 OF0gIGt0aHJlYWQrMHhmZi8weDE0MAo+IFsgICA2Mi4wMzQ5NThdICA/IHByb2Nlc3Nfb25lX3dv cmsrMHgzZTAvMHgzZTAKPiBbICAgNjIuMDM0OTU5XSAgPyBrdGhyZWFkX2NyZWF0ZV9vbl9ub2Rl Kwo+IAo+IGFuZCByZWxhdGVkIGhhcmQgbG9ja3VwcyBpbiBDSSBmb3IgYnl0IGFuZCBic3cuCj4g Cj4gTm90ZSB0aGlzIGVmZmVjdGl2ZWx5IHJldmVydHMgY29tbWl0cyA0MWNlNDA1ZTY4OTQgYW5k IGIyNzM2Njk1ODg2OQo+ICgiZHJtL2k5MTU6IENvbnZlcnQgd2FpdF9mb3IoSTkxNV9SRUFEKHJl ZykpIHRvIGludGVsX3dhaXRfZm9yX3JlZ2lzdGVyKCkiKQo+IAo+IEZpeGVzOiA0MWNlNDA1ZTY4 OTQgKCJkcm0vaTkxNTogQ29udmVydCB3YWl0X2ZvcihJOTE1X1JFQUQocmVnKSkgdG8gaW50ZWxf d2FpdF9mb3JfcmVnaXN0ZXIoKSIpCj4gRml4ZXM6IGIyNzM2Njk1ODg2OSAoImRybS9pOTE1OiBD b252ZXJ0IHdhaXRfZm9yKEk5MTVfUkVBRChyZWcpKSB0byBpbnRlbF93YWl0X2Zvcl9yZWdpc3Rl cigpIikKPiBCdWd6aWxsYTogaHR0cHM6Ly9idWdzLmZyZWVkZXNrdG9wLm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTAwNzE4Cj4gU2lnbmVkLW9mZi1ieTogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13 aWxzb24uY28udWs+Cj4gQ2M6IFR2cnRrbyBVcnN1bGluIDx0dnJ0a28udXJzdWxpbkBpbnRlbC5j b20+Cj4gQ2M6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+ Cj4gQ2M6IFRvbWkgU2FydmVsYSA8dG9taS5wLnNhcnZlbGFAaW50ZWwuY29tPgo+IC0tLQo+ICBk cml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5jIHwgMzkgKysrKysrKysrKysrKysrKystLS0t LS0tLS0tLS0tLS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAxNyBpbnNlcnRpb25zKCspLCAy MiBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkx NV9kcnYuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmMKPiBpbmRleCBlNGY5MDJm NjFlNTcuLjg5YjUxN2M0NzhlOCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p OTE1X2Rydi5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuYwo+IEBAIC0y MTc5LDYgKzIxNzksMTcgQEAgc3RhdGljIHZvaWQgdmx2X3Jlc3RvcmVfZ3VuaXRfczBpeF9zdGF0 ZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gIAlJOTE1X1dSSVRFKFZMVl9H VU5JVF9DTE9DS19HQVRFMiwJcy0+Y2xvY2tfZ2F0ZV9kaXMyKTsKPiAgfQo+ICAKPiArc3RhdGlj IGludCB2bHZfd2FpdF9mb3JfcHdfc3RhdHVzKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZf cHJpdiwKPiArCQkJCSAgdTMyIG1hc2ssIHUzMiB2YWwpCj4gK3sKPiArCS8qIFRoZSBIVyBkb2Vz IG5vdCBsaWtlIHVzIHBvbGxpbmcgZm9yIFBXX1NUQVRVUyBmcmVxdWVudGx5LCBzbwo+ICsJICog dXNlIHRoZSBzbGVlcGluZyBsb29wIHJhdGhlciB0aGFuIHJpc2sgdGhlIGJ1c3kgc3BpbiB3aXRo aW4KPiArCSAqIGludGVsX3dhaXRfZm9yX3JlZ2lzdGVyKCkuCj4gKwkgKi8KPiArCXJldHVybiB3 YWl0X2ZvcigoSTkxNV9SRUFEX05PVFJBQ0UoVkxWX0dUTENfUFdfU1RBVFVTKSAmIG1hc2spID09 IHZhbCwKPiArCQkJMyk7Cj4gK30KPiArCj4gIGludCB2bHZfZm9yY2VfZ2Z4X2Nsb2NrKHN0cnVj dCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwgYm9vbCBmb3JjZV9vbikKPiAgewo+ICAJdTMy IHZhbDsKPiBAQCAtMjIwOCw3ICsyMjE5LDcgQEAgaW50IHZsdl9mb3JjZV9nZnhfY2xvY2soc3Ry dWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LCBib29sIGZvcmNlX29uKQo+ICBzdGF0aWMg aW50IHZsdl9hbGxvd19ndF93YWtlKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwg Ym9vbCBhbGxvdykKPiAgewo+ICAJdTMyIHZhbDsKPiAtCWludCBlcnIgPSAwOwo+ICsJaW50IGVy cjsKPiAgCj4gIAl2YWwgPSBJOTE1X1JFQUQoVkxWX0dUTENfV0FLRV9DVFJMKTsKPiAgCXZhbCAm PSB+VkxWX0dUTENfQUxMT1dXQUtFUkVROwo+IEBAIC0yMjE3LDQ1ICsyMjI4LDI5IEBAIHN0YXRp YyBpbnQgdmx2X2FsbG93X2d0X3dha2Uoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2 LCBib29sIGFsbG93KQo+ICAJSTkxNV9XUklURShWTFZfR1RMQ19XQUtFX0NUUkwsIHZhbCk7Cj4g IAlQT1NUSU5HX1JFQUQoVkxWX0dUTENfV0FLRV9DVFJMKTsKPiAgCj4gLQllcnIgPSBpbnRlbF93 YWl0X2Zvcl9yZWdpc3RlcihkZXZfcHJpdiwKPiAtCQkJCSAgICAgIFZMVl9HVExDX1BXX1NUQVRV UywKPiAtCQkJCSAgICAgIFZMVl9HVExDX0FMTE9XV0FLRUFDSywKPiAtCQkJCSAgICAgIGFsbG93 LAo+IC0JCQkJICAgICAgMSk7Cj4gKwllcnIgPSB2bHZfd2FpdF9mb3JfcHdfc3RhdHVzKGRldl9w cml2LCBWTFZfR1RMQ19BTExPV1dBS0VBQ0ssIGFsbG93KTsKCkxvb2tzIGEgYml0IGZ1bm55IHRv IHdhaXQgZm9yIGEgYm9vbGVhbi4gTWF5YmUgJ2FsbG93ID8gVkxWX0dUTENfQUxMT1dXQUtFQUNL IDogMCcKdG8gbWFrZSB0aGlzIGEgbGl0dGxlIGxlc3MgY29uZnVzaW5nPyAKCj4gIAlpZiAoZXJy KQo+ICAJCURSTV9FUlJPUigidGltZW91dCBkaXNhYmxpbmcgR1Qgd2FraW5nXG4iKTsKPiAgCj4g IAlyZXR1cm4gZXJyOwo+ICB9Cj4gIAo+IC1zdGF0aWMgaW50IHZsdl93YWl0X2Zvcl9ndF93ZWxs cyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gLQkJCQkgYm9vbCB3YWl0X2Zv cl9vbikKPiArc3RhdGljIHZvaWQgdmx2X3dhaXRfZm9yX2d0X3dlbGxzKHN0cnVjdCBkcm1faTkx NV9wcml2YXRlICpkZXZfcHJpdiwKPiArCQkJCSAgYm9vbCB3YWl0X2Zvcl9vbikKPiAgewo+ICAJ dTMyIG1hc2s7Cj4gIAl1MzIgdmFsOwo+IC0JaW50IGVycjsKPiAgCj4gIAltYXNrID0gVkxWX0dU TENfUFdfTUVESUFfU1RBVFVTX01BU0sgfCBWTFZfR1RMQ19QV19SRU5ERVJfU1RBVFVTX01BU0s7 Cj4gIAl2YWwgPSB3YWl0X2Zvcl9vbiA/IG1hc2sgOiAwOwo+IC0JaWYgKChJOTE1X1JFQUQoVkxW X0dUTENfUFdfU1RBVFVTKSAmIG1hc2spID09IHZhbCkKPiAtCQlyZXR1cm4gMDsKPiAtCj4gLQlE Uk1fREVCVUdfS01TKCJ3YWl0aW5nIGZvciBHVCB3ZWxscyB0byBnbyAlcyAoJTA4eClcbiIsCj4g LQkJICAgICAgb25vZmYod2FpdF9mb3Jfb24pLAo+IC0JCSAgICAgIEk5MTVfUkVBRChWTFZfR1RM Q19QV19TVEFUVVMpKTsKPiAgCj4gIAkvKgo+ICAJICogUkM2IHRyYW5zaXRpb25pbmcgY2FuIGJl IGRlbGF5ZWQgdXAgdG8gMiBtc2VjIChzZWUKPiAgCSAqIHZhbGxleXZpZXdfZW5hYmxlX3Jwcyks IHVzZSAzIG1zZWMgZm9yIHNhZmV0eS4KPiAgCSAqLwoKTWF5YmUgbW92ZSB0aGUgY29tbWVudCBp bnRvIHZsdl93YWl0X2Zvcl9wd19zdGF0dXMoKSBhcyB3ZWxsIHNpbmNlIHRoYXQncwp3aGVyZSB0 aGUgdGltZW91dCBpcyBzcGVjaWZpZWQgbm93PwoKSGF2ZW4ndCB2ZXJmaWVkIHRoZSBoYXJkd2Fy ZSBpc3N1ZSBteXNlbGYsIGJ1dCB0aGUgY2hhbmdlIGxvb2tzIHNhbmUgZW5vdWdoLCBzbwpSZXZp ZXdlZC1ieTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4K Cj4gLQllcnIgPSBpbnRlbF93YWl0X2Zvcl9yZWdpc3RlcihkZXZfcHJpdiwKPiAtCQkJCSAgICAg IFZMVl9HVExDX1BXX1NUQVRVUywgbWFzaywgdmFsLAo+IC0JCQkJICAgICAgMyk7Cj4gLQlpZiAo ZXJyKQo+ICsJaWYgKHZsdl93YWl0X2Zvcl9wd19zdGF0dXMoZGV2X3ByaXYsIG1hc2ssIHZhbCkp Cj4gIAkJRFJNX0VSUk9SKCJ0aW1lb3V0IHdhaXRpbmcgZm9yIEdUIHdlbGxzIHRvIGdvICVzXG4i LAo+ICAJCQkgIG9ub2ZmKHdhaXRfZm9yX29uKSk7Cj4gLQo+IC0JcmV0dXJuIGVycjsKPiAgfQo+ ICAKPiAgc3RhdGljIHZvaWQgdmx2X2NoZWNrX25vX2d0X2FjY2VzcyhzdHJ1Y3QgZHJtX2k5MTVf cHJpdmF0ZSAqZGV2X3ByaXYpCj4gQEAgLTIyNzYsNyArMjI3MSw3IEBAIHN0YXRpYyBpbnQgdmx2 X3N1c3BlbmRfY29tcGxldGUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICAJ ICogQnNwZWMgZGVmaW5lcyB0aGUgZm9sbG93aW5nIEdUIHdlbGwgb24gZmxhZ3MgYXMgZGVidWcg b25seSwgc28KPiAgCSAqIGRvbid0IHRyZWF0IHRoZW0gYXMgaGFyZCBmYWlsdXJlcy4KPiAgCSAq Lwo+IC0JKHZvaWQpdmx2X3dhaXRfZm9yX2d0X3dlbGxzKGRldl9wcml2LCBmYWxzZSk7Cj4gKwl2 bHZfd2FpdF9mb3JfZ3Rfd2VsbHMoZGV2X3ByaXYsIGZhbHNlKTsKPiAgCj4gIAltYXNrID0gVkxW X0dUTENfUkVOREVSX0NUWF9FWElTVFMgfCBWTFZfR1RMQ19NRURJQV9DVFhfRVhJU1RTOwo+ICAJ V0FSTl9PTigoSTkxNV9SRUFEKFZMVl9HVExDX1dBS0VfQ1RSTCkgJiBtYXNrKSAhPSBtYXNrKTsK PiAtLSAKPiAyLjExLjAKCi0tIApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwgT1RDCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxp c3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNr dG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=