From: "Pali Rohár" <pali.rohar@gmail.com>
To: Pan Bian <bianpan2016@163.com>
Cc: Sebastian Reichel <sre@kernel.org>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] power: check return value of devm_kzalloc
Date: Sun, 23 Apr 2017 21:44:33 +0200 [thread overview]
Message-ID: <201704232144.33603@pali> (raw)
In-Reply-To: <1492938236-9928-1-git-send-email-bianpan2016@163.com>
[-- Attachment #1: Type: Text/Plain, Size: 467 bytes --]
On Sunday 23 April 2017 11:03:56 Pan Bian wrote:
> pdata = devm_kzalloc(&pdev->dev,
> sizeof(struct isp1704_charger_data), GFP_KERNEL);
> + if (!pdata)
> + return -ENOMEM;
> pdata->enable_gpio = gpio;
>
> dev_info(&pdev->dev, "init gpio %d\n", pdata->enable_gpio);
What about calling "goto fail0", so there will be error message about
failure of registering isp1704 like for any other failures?
--
Pali Rohár
pali.rohar@gmail.com
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
prev parent reply other threads:[~2017-04-23 19:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-23 9:03 [PATCH 1/1] power: check return value of devm_kzalloc Pan Bian
2017-04-23 19:44 ` Pali Rohár [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201704232144.33603@pali \
--to=pali.rohar@gmail.com \
--cc=bianpan2016@163.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.