From: Pavel Machek <pavel@ucw.cz>
To: David Lin <dtwlin@google.com>
Cc: rpurdie@rpsys.net, jacek.anaszewski@gmail.com, robh@kernel.org,
romlem@google.com, joelaf@google.com, stable@vger.kernel.org,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] led: ledtrig-transient: replace timer_list with hrtimer
Date: Mon, 24 Apr 2017 09:44:17 +0200 [thread overview]
Message-ID: <20170424074417.GA24242@amd> (raw)
In-Reply-To: <20170424044254.145192-1-dtwlin@google.com>
[-- Attachment #1: Type: text/plain, Size: 890 bytes --]
On Sun 2017-04-23 21:42:54, David Lin wrote:
> This patch replaces the kernel timer used by led transient trigger as an
> one-shot timer with an hrtimer. As Android is moving away from the
> obsoleted timed_output to ledtrig-transient for the vibrator HAL,
> ledtrig-transient needs to be able to handle the "duration" property to
> millisecond precision as modern haptic actuators can be driven in
> precisely one cycle (~1 ms) in order to provide a crisp and subtle
> feedback.
(Insert rant about using LED subsystem for something that is not a
LED; if we are going to these subtleties, LEDs _do_ have different
properties than vibration motor...).
Otherwise it looks good.
Acked-by: Pavel Machek <pavel@ucw.cz>
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2017-04-24 7:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-24 4:42 [PATCH] led: ledtrig-transient: replace timer_list with hrtimer David Lin
2017-04-24 7:44 ` Pavel Machek [this message]
2017-04-24 19:59 ` Jacek Anaszewski
2017-04-24 20:18 ` Pavel Machek
2017-04-25 3:05 ` David Lin
2017-04-25 20:15 ` Jacek Anaszewski
2017-04-27 3:48 ` David Lin
2017-04-27 18:37 ` Jacek Anaszewski
2017-04-25 22:34 ` Pavel Machek
2017-04-26 19:49 ` Jacek Anaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170424074417.GA24242@amd \
--to=pavel@ucw.cz \
--cc=dtwlin@google.com \
--cc=jacek.anaszewski@gmail.com \
--cc=joelaf@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=robh@kernel.org \
--cc=romlem@google.com \
--cc=rpurdie@rpsys.net \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.