All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fam Zheng <famz@redhat.com>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org,
	Eric Blake <eblake@redhat.com>, Max Reitz <mreitz@redhat.com>,
	Kevin Wolf <kwolf@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v5 3/4] qemu-img: introduce --target-image-opts for 'convert' command
Date: Mon, 24 Apr 2017 17:45:12 +0800	[thread overview]
Message-ID: <20170424094512.GC14416@lemon.lan> (raw)
In-Reply-To: <20170424091659.26708-4-berrange@redhat.com>

On Mon, 04/24 10:16, Daniel P. Berrange wrote:
> The '--image-opts' flags indicates whether the source filename

s/flags/flag/ or s/indicates/indicate/, I think?

> includes options. The target filename has to remain in the
> plain filename format though, since it needs to be passed to
> bdrv_create().  When using --skip-create though, it would be
> possible to use image-opts syntax. This adds --target-image-opts
> to indicate that the target filename includes options. Currently
> this mandates use of the --skip-create flag too.

Fam

  reply	other threads:[~2017-04-24  9:45 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-24  9:16 [Qemu-devel] [PATCH v5 0/4] Improve convert and dd commands Daniel P. Berrange
2017-04-24  9:16 ` [Qemu-devel] [PATCH v5 1/4] qemu-img: add support for --object with 'dd' command Daniel P. Berrange
2017-04-24  9:16 ` [Qemu-devel] [PATCH v5 2/4] qemu-img: fix --image-opts usage with dd command Daniel P. Berrange
2017-04-24  9:16 ` [Qemu-devel] [PATCH v5 3/4] qemu-img: introduce --target-image-opts for 'convert' command Daniel P. Berrange
2017-04-24  9:45   ` Fam Zheng [this message]
2017-04-24  9:46     ` Daniel P. Berrange
2017-04-26 19:23   ` Max Reitz
2017-04-27  8:43     ` Daniel P. Berrange
2017-04-24  9:16 ` [Qemu-devel] [PATCH v5 4/4] qemu-img: copy *key-secret opts when opening newly created files Daniel P. Berrange
2017-04-24  9:50   ` Fam Zheng
2017-04-26 19:37   ` Max Reitz
2017-04-24  9:51 ` [Qemu-devel] [PATCH v5 0/4] Improve convert and dd commands Fam Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170424094512.GC14416@lemon.lan \
    --to=famz@redhat.com \
    --cc=berrange@redhat.com \
    --cc=eblake@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.