All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrea della Porta <sfaragnaus@gmail.com>
To: Oleg Drokin <oleg.drokin@intel.com>,
	Andreas Dilger <andreas.dilger@intel.com>,
	James Simmons <jsimmons@infradead.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	lustre-devel@lists.lustre.org, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH] drivers: staging: lustre: lustre: llite: file.c - fixed sparse warning about different fmode_t type
Date: Mon, 24 Apr 2017 11:28:58 +0100	[thread overview]
Message-ID: <20170424102858.GA1471@gmail.com> (raw)

Fixed the following sparse warning:

  CHECK   drivers/staging/lustre/lustre/llite//file.c
  drivers/staging/lustre/lustre/llite//file.c:441:24: warning: incorrect
  type in assignment (different base types)
  drivers/staging/lustre/lustre/llite//file.c:441:24:    expected
  restricted fmode_t [usertype] och_flags
  drivers/staging/lustre/lustre/llite//file.c:441:24:    got unsigned
  long long [unsigned] [usertype] it_flags
  drivers/staging/lustre/lustre/llite//file.c:465:65: warning:
  restricted fmode_t degrades to integer
  drivers/staging/lustre/lustre/llite//file.c:465:22: warning: incorrect
  type in assignment (different base types)
  drivers/staging/lustre/lustre/llite//file.c:465:22:    expected
  restricted fmode_t [usertype] fd_omode
  drivers/staging/lustre/lustre/llite//file.c:465:22:    got unsigned
  long long
  drivers/staging/lustre/lustre/llite//file.c:526:38: warning: invalid
  assignment: |=
  drivers/staging/lustre/lustre/llite//file.c:526:38:    left side has
  type unsigned long long
  drivers/staging/lustre/lustre/llite//file.c:526:38:    right side has
  type restricted fmode_t
  drivers/staging/lustre/lustre/llite//file.c:533:49: warning:
  restricted fmode_t degrades to integer
  drivers/staging/lustre/lustre/llite//file.c:553:28: warning:
  restricted fmode_t degrades to integer
  drivers/staging/lustre/lustre/llite//file.c:556:35: warning:
  restricted fmode_t degrades to integer
  drivers/staging/lustre/lustre/llite//file.c:778:23: warning:
  restricted fmode_t degrades to integer
  drivers/staging/lustre/lustre/llite//file.c:1309:62: warning:
  restricted fmode_t degrades to integer
  drivers/staging/lustre/lustre/llite//file.c:1357:23: warning:
  incorrect type in initializer (different base types)
  drivers/staging/lustre/lustre/llite//file.c:1357:23:    expected
  unsigned long long [unsigned] [usertype] flags
  drivers/staging/lustre/lustre/llite//file.c:1357:23:    got restricted
  fmode_t [usertype] <noident>


Signed-off-by: Andrea della Porta <sfaragnaus@gmail.com>
---
 drivers/staging/lustre/lustre/include/lustre_intent.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/lustre/lustre/include/lustre_intent.h b/drivers/staging/lustre/lustre/include/lustre_intent.h
index ed2b6c6..c036633 100644
--- a/drivers/staging/lustre/lustre/include/lustre_intent.h
+++ b/drivers/staging/lustre/lustre/include/lustre_intent.h
@@ -38,7 +38,7 @@
 struct lookup_intent {
 	int		it_op;
 	int		it_create_mode;
-	__u64		it_flags;
+	fmode_t		it_flags;
 	int		it_disposition;
 	int		it_status;
 	__u64		it_lock_handle;
-- 
2.4.10

             reply	other threads:[~2017-04-28 10:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-24 10:28 Andrea della Porta [this message]
2017-06-03  8:31 ` [lustre-devel] [PATCH] drivers: staging: lustre: lustre: llite: file.c - fixed sparse warning about different fmode_t type Greg Kroah-Hartman
2017-06-03  8:31   ` Greg Kroah-Hartman
  -- strict thread matches above, loose matches on Subject: below --
2017-04-24  6:53 Andrea della Porta
2017-04-28  7:30 ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170424102858.GA1471@gmail.com \
    --to=sfaragnaus@gmail.com \
    --cc=andreas.dilger@intel.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jsimmons@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lustre-devel@lists.lustre.org \
    --cc=oleg.drokin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.