Re: PM issue with Intel SST Atom driver

[Vinod Koul <vinod.koul@intel.com>]

On Mon, Apr 24, 2017 at 11:54:06AM +0200, Takashi Iwai wrote:
> On Mon, 24 Apr 2017 11:52:44 +0200,
> Vinod Koul wrote:
> > 
> > On Mon, Apr 24, 2017 at 11:43:47AM +0200, Takashi Iwai wrote:
> > > On Mon, 24 Apr 2017 11:12:14 +0200,
> > > Vinod Koul wrote:
> > > > 
> > > > On Mon, Apr 24, 2017 at 11:00:45AM +0200, Takashi Iwai wrote:
> > > >  
> > > > > Removing ignore_suspend makes the PM succeeds.  But it hits some other
> > > > > ugly kernel bugs.
> > > > 
> > > > Okay have you marked .nonatomic = true for the machine DAIs?
> > > 
> > > Ah that's it.  The patch below seems fixing the PM and the nonatomic
> > > problems.  I'm not sure about the nonatomic flag for the compress
> > > stream, though.
> > 
> > Well we dont have upstream decoders so it wont be used in this case.
> > 
> > > Also I fiddled only with FE.  Do we need the same flags for BE?  The
> > > others don't look setting like that, so I left so.
> > 
> > I dont remember if BE needs or not FE should suffice.
> 
> OK then I leave it as is.
> 
> When I submit the fix, I should put Cc to stable, and wonder which
> version we assure the nonatomic ops in SST driver.  Did the code base
> support nonatomic ops from the beginning?

4.1 onwards.

The PM was supported thru below commit which went into 4.1.  The nonatomic
was always a requirement for us due to nature of IPC. Non atomic support
went into 3.18 so 4.1 onwards would make sense :)

commit 4a8448d4289d7210053a43f9f21e42929beb159b
Author: Vinod Koul <vinod.koul@intel.com>
Date:   Tue Feb 24 11:39:44 2015 +0530

    ASoC: Intel: add pm support in sst ipc driver

    This adds support for system pm support. We need to save the dsp memory
    which gets lost on suspend and restore that on resume

    Signed-off-by: Subhransu S. Prusty <subhransu.s.prusty@intel.com>
    Signed-off-by: Vinod Koul <vinod.koul@intel.com>
    Signed-off-by: Mark Brown <broonie@kernel.org>

Thanks
-- 
~Vinod